From: Geoff Keating <geoffk@geoffk.org>
To: martin@v.loewis.de (Martin v. Loewis)
Cc: gcc@gcc.gnu.org, Paolo Bonzini <bonzini@gnu.org>
Subject: Re: Status of i18n patches (again)
Date: Sun, 27 Oct 2002 12:40:00 -0000 [thread overview]
Message-ID: <jmr8edorj5.fsf@desire.geoffk.org> (raw)
In-Reply-To: <m3y98lkpbk.fsf@mira.informatik.hu-berlin.de>
martin@v.loewis.de (Martin v. Loewis) writes:
> http://gcc.gnu.org/ml/gcc-patches/2002-06/msg01620.html
I looked at this patch, and have the following comments:
- The patch appears to do many different classes of things. It should
be broken up into one patch for each group of changes in the ChangeLog.
Some can be approved very quickly. The remainder will take longer.
- The patch creates a new source file containing only strings. This
seems out-of-place with the design of the i18n machinery, which is
that strings exist in the source code, not out-of-line in some other
file. It might be better to:
- Instead pass some other constant down to the diagnostic machinery,
like the decl of the object in question or its TREE_CODE; or
- Pass those strings down to the routine, for instance
check_for_new_type (..., "within exception specifier"); or
- Localise the combined string (that is, call gettext after calling
sprintf), although you then have to work out how to tell xgettext
what the possibilities are.
As an indication of why this might be a good idea, this patch gets the
check_for_new_type (..., "exception specifier");
case wrong.
- Please consider writing testcases for any significant changes, if
you can.
--
- Geoffrey Keating <geoffk@geoffk.org>
prev parent reply other threads:[~2002-10-26 20:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-27 10:28 Martin v. Loewis
2002-10-27 12:40 ` Geoff Keating [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jmr8edorj5.fsf@desire.geoffk.org \
--to=geoffk@geoffk.org \
--cc=bonzini@gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=martin@v.loewis.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).