From: Denis Chertykov <denisc@overta.ru>
To: Eric Christopher <echristo@apple.com>
Cc: Denis Chertykov <denisc@overta.ru>, gcc@gcc.gnu.org
Subject: Re: CAN_ELIMINATE question
Date: Mon, 13 Feb 2006 19:07:00 -0000 [thread overview]
Message-ID: <lkwfgjni.fsf@overta.ru> (raw)
In-Reply-To: <93106CFF-7969-45F5-B56B-70CFBBBEAD83@apple.com>
Eric Christopher <echristo@apple.com> writes:
> On Feb 13, 2006, at 7:43 AM, Denis Chertykov wrote:
>
> > Hi All.
> >
> > While I have debugging AVR target bug I found that something wrong in
> > port code or in reload.
> >
> > Is it right to use of get_frame_size() inside CAN_ELIMINATE macro
> > valid ?
> > If yes then reload have a bug.
> > If no then AVR and probably MIPS ports have invalid definitions of
> > CAN_ELIMINATE.
>
> Can you point to where you think reload is getting this wrong?
Yes.
Code fragment from reload1.c: reload()
----------------------------------------------------
if (caller_save_needed)
setup_save_areas ();
/* If we allocated another stack slot, redo elimination bookkeeping. */
if (starting_frame_size != get_frame_size ())
continue;
if (caller_save_needed)
{
save_call_clobbered_regs ();
/* That might have allocated new insn_chain structures. */
reload_firstobj = obstack_alloc (&reload_obstack, 0);
}
calculate_needs_all_insns (global);
----------------------------------------------------
Call to setup_save_areas () can change frame size but only offsets on
eliminable registers will be changed before call to calculate_needs_all_insns.
calculate_needs_all_insns will calculate wrong needs for elimination.
Example for AVR:
avr target can eliminate fp -> sp only if get_frame_size () == 0.
Before call to setup_save_areas() frame size was 0 (CAN_ELIMINATE (FP,SP) != 0)
setup_save_areas() increase frame size.
set_initial_elim_offsets() correct offsets but can_eliminate isn't changed.
save_call_clobbered_regs () emit save insn
(insn 659 161 162 16 (set (mem/c:HI (plus:HI (reg/f:HI 28 r28) # it's FP
(const_int 1 [0x1])) [29 S2 A8])
(reg:HI 24 r24)) 12 {*movhi} (nil)
(nil))
calculate_needs_all_insns() try to eliminate (reg/f:HI 28 r28) to SP.
It's wrong because get_frame_size () != 0 and CAN_ELIMINATE (FP,SP) == 0
I think that better to call update_eliminables() somewhere after
setup_save_areas()
Denis.
next prev parent reply other threads:[~2006-02-13 19:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 15:43 Denis Chertykov
2006-02-13 17:48 ` Eric Christopher
2006-02-13 19:07 ` Denis Chertykov [this message]
2006-02-15 23:48 ` Ian Lance Taylor
2006-02-16 17:28 ` Denis Chertykov
2006-02-16 23:56 ` Ian Lance Taylor
2006-02-17 17:49 ` Denis Chertykov
2006-03-28 20:45 ` Denis Chertykov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lkwfgjni.fsf@overta.ru \
--to=denisc@overta.ru \
--cc=echristo@apple.com \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).