From: H.J. Lu <hjl@lucon.org>
To: egcs@cygnus.com
Subject: Re: prototyping
Date: Sun, 17 Aug 1997 21:48:08 -0000 [thread overview]
Message-ID: <m0x0C8V-0004ecC@ocean.lucon.org> (raw)
In-Reply-To: 5199.871844794@hurl.cygnus.com
>
> In message <m0x07ER-0004ecC@ocean.lucon.org>you write:
> > I am thinking the other way around since I have removed those
> > incomplete external function declarations in .c files, using the
> > ones in .h files instead. I will first send in patches for .h files,
> > then .c files.
> That's just as good of a place to start.
>
It dosen't work very well. There are so many inter-dependencies among
.h files as well as .h and .c files. Since there are no major code
changes in my prototype patch, maybe it is a better idea for me to
create a jumbo patch. Someone may just have to take a few hours to
double check my changes before checking them in. I know it is a tedious
job. But at least you don't have to worry about if I changed any code
logic. I think it is worth it.
--
H.J. Lu (hjl@gnu.ai.mit.edu)
WARNING: multiple messages have this Message-ID
From: Jeffrey A Law <law@hurl.cygnus.com>
To: egcs@cygnus.com
Subject: Re: prototyping
Date: Sun, 17 Aug 1997 21:48:08 -0000 [thread overview]
Message-ID: <m0x0C8V-0004ecC@ocean.lucon.org> (raw)
Message-ID: <19970817214808.v1yPX3_6wxDGwGNXsC5N9gkECcMg5339Z6zARPABsdQ@z> (raw)
In-Reply-To: prototyping
In message <m0x0C8V-0004ecC@ocean.lucon.org>you write:
> >
> > In message <m0x07ER-0004ecC@ocean.lucon.org>you write:
> > > I am thinking the other way around since I have removed those
> > > incomplete external function declarations in .c files, using the
> > > ones in .h files instead. I will first send in patches for .h files,
> > > then .c files.
> > That's just as good of a place to start.
> >
>
> It dosen't work very well.
I don't see why.
Go into a .c file, remove all the prototypes for extern things and
put them into an appropriate .h file. Remove all other prototypes
for those same things from other .c files.
Submit patch.
Repeat for another .c file.
This is _much_ easier to understand and verify than a jumbo patch.
Jeff
next reply other threads:[~1997-08-17 21:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
1997-08-17 21:48 H.J. Lu [this message]
1997-08-17 21:48 ` prototyping Jeffrey A Law
-- strict thread matches above, loose matches on Subject: below --
1997-08-18 18:22 prototyping Per Bothner
1997-08-18 15:11 Reload patch to improve 386 code meissner
1997-08-18 15:36 ` prototyping Jeffrey A Law
1997-08-18 8:22 2 (small?) problems Thomas Hiller
1997-08-18 9:11 ` prototyping Andi Kleen
1997-08-17 21:55 prototyping H.J. Lu
1997-08-17 22:18 ` prototyping Jeffrey A Law
1997-08-17 18:01 970814 and libg++ Mumit Khan
1997-08-17 19:06 ` prototyping Jeffrey A Law
1997-08-17 17:52 prototyping Per Bothner
1997-08-17 14:30 prototyping H.J. Lu
1997-08-16 23:30 egcs-ss-970814 David S. Miller
1997-08-17 14:30 ` prototyping Jeffrey A Law
1997-08-16 19:16 prototyping Per Bothner
1997-08-16 17:50 prototyping H.J. Lu
1997-08-16 14:00 prototyping John Carr
1997-08-16 5:24 two ftp mirrors of egcs are up Ryuichiro ARAKI
1997-08-16 5:37 ` prototyping Jeffrey A Law
1997-08-16 3:51 prototyping H.J. Lu
1997-08-16 3:18 prototyping H.J. Lu
1997-08-16 3:51 ` prototyping Jeffrey A Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m0x0C8V-0004ecC@ocean.lucon.org \
--to=hjl@lucon.org \
--cc=egcs@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).