public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeffrey A Law <law@hurl.cygnus.com>
To: egcs@cygnus.com
Subject: Re: Some Haifa scheduler bugs
Date: Tue, 19 Aug 1997 19:00:07 -0000	[thread overview]
Message-ID: <m0x0seU-0004ecC@ocean.lucon.org> (raw)
In-Reply-To: Some Haifa scheduler bugs

  In message <Pine.SOL.3.90.970819092828.291B-100000@starsky.informatik.rwth-aa
chen.de>you write:
  > 	* haifa-sched.c (target_bb, bbset_size, dom, prob, rgn_nr_edges,
  > 	rgn_edges, edgeset_size, edge_to_bit, pot_split, ancestor_edges):
  > 	Make static.
I've already got these installed into egcs, plus some others that
you didn't make static.

  > 	(move_insn): Call reemit_notes for every insn in a SCHED_GROUP.
See my last message -- that's the code I'm running right now.  If it
doesn't work, let me know and we can iterate to a solution.

  > 	(schedule_block): When checking whether an insn is the 
  > 	basic_block_head of a different block, use the first insn in the
  > 	same SCHED_GROUP instead of the insn itself.
Done.  Slightly differently, but should be functionally equivalent
and a little clearer to someone who might read the code later.


  > 	(debug_dependencies): GET_RTX_NAME takes an rtx code, not an rtx.
Done.

Jeff

WARNING: multiple messages have this Message-ID
From: H.J. Lu <hjl@lucon.org>
To: egcs@cygnus.com
Subject: Re: A prototype patch for tree.h/tree.def/calls.c
Date: Tue, 19 Aug 1997 19:00:07 -0000	[thread overview]
Message-ID: <m0x0seU-0004ecC@ocean.lucon.org> (raw)
Message-ID: <19970819190007.fpZg_1Zji9HKAGbSSrBGTCcfTj-wZfsYRWhk6s5pSq4@z> (raw)
In-Reply-To: 199708191752.NAA20687@department-of-alchemy.MIT.EDU

> 
> 
> > #define NEED_enum_rtx_code    
> > #include "rtl.def"                
> > #undef NEED_enum_rtx_code                                        
> > #define NEED_enum_machine_mode                                     
> > #include "machmode.def"               
> > #undef NEED_enum_machine_mode                       
> > 
> > .....
> > extern int ix86_expand_binary_operator 
> >         PROTO ((enum rtx_code, enum machine_mode, struct rtx_def *[]));
> > .....
> 
> This looks ugly.  I agree with Kenner's comments a while back about
> changes to the #include conventions in gcc.  Target .h files shouldn't
> need to include any gcc files.  We should minimize nested includes
> within gcc.

It does look ugly. But it works.

> 
> There are a few ways to solve the problem of the target .h file
> needing more definitions.
> 
> We could make the rtl and tree definitions visible in every gcc file
> (like the machine modes are now).  Then tm.h would have all types
> available.
> 
> We could require tm.h to test whether it is being used in a front-end
> or back-end context and not use any names not defined in that context.
> 
> Either of these requires rtl.h (less the very few target-dependent
> macros) or tree.h to be included _before_ tm.h.  The changes are
> simple but almost every file in gcc (including machine descriptions)
> would need to change.  If we plan to do a front/middle/back-end
> interface cleanup it would be best to defer the changes until then and
> make them all at once.

I have spent the time to make a patch. Why should we wait for something
which noone knows when it will be ever done? Besides my patch is small
enough that it is easy to take out.

> 
> Another option is to declare function arguments as integers instead of
> enumerated types in tm.{c,h}.
> 

I don't know if it is a good idea since those *.def are included
multiple time to have a correct match.


-- 
H.J. Lu (hjl@gnu.ai.mit.edu)

WARNING: multiple messages have this Message-ID
From: Jeffrey A Law <law@hurl.cygnus.com>
To: egcs@cygnus.com
Subject: Re: A prototype patch for tree.h/tree.def/calls.c
Date: Tue, 19 Aug 1997 19:00:07 -0000	[thread overview]
Message-ID: <m0x0seU-0004ecC@ocean.lucon.org> (raw)
Message-ID: <19970819190007.ZJK2lZf9UXflSStzlaPuX1gGnRFARK7gCVzTlsFGETM@z> (raw)
In-Reply-To: A prototype patch for tree.h/tree.def/calls.c

  In message <m0x0r16-0004edC@ocean.lucon.org>you write:
  > > 
  > >   In message <m0x0opG-0004edC@ocean.lucon.org>you write:
  > >   > I have some problem s with my emails for the past few days. I may
  > >   > have lost some. I only remember your comments on BUFSIZ being a macro
  > ,
  > >   > which turned out ok. What else?
  > > Relatively minor stuff.
  > > 
  > > For this pass #if 0 the prototypes for xmalloc and related funtions;
  > > once the bulk of the prototypes are in, please submit a separate
  > > patch to enable prototyping of xmalloc and related functions.
  > 
  > On my machine, they are enabled.
Please disable them for the patch.

  > That is exactly the problem with size_t. How can you be
  > sure size_t is available on all systems when xmalloc ()
  > is used? many xmalloc () in gcc use unsigned. I think
  > it makes some senses.
NO!  You simply can't change from size_t to unsigned, that's
just plain wrong.

Seems to me the right way to do this is with autoconf.


  > I have spent weeks on it. I am afraid I may make some
  > stupid mistakes if I try to reformat it. After all,
  > those prototypes are mainly for compiler. Please feel
  > free to reformat it. Thanks.
Then they're not likely to go in anytime soon.  I don't have the
time to spend reformatting all your changes.

  > Here is what I have in my i386.h:
  > 
  > #define NEED_enum_rtx_code    
  > #include "rtl.def"                
  > #undef NEED_enum_rtx_code                                        
  > #define NEED_enum_machine_mode                                     
  > #include "machmode.def"               
  > #undef NEED_enum_machine_mode                       
I had a feeling you'd done something like this -- let's punt this
for now until we can come up with something better.


So, it seems to me you need to do 3 things:

  * #if0 the xmalloc and friends prototypes.
  * Don't mess with the enum rtx_code and enum tree_code stuff
    right now.
  * Do some minor formatting.

We're not talking about a lot of work that you'd need to do to
get your patches installed immediately.

Jeff

WARNING: multiple messages have this Message-ID
From: Dan A. Dickey <ddickey@transition.com>
To: egcs@cygnus.com
Subject: Re: Unique SMTP From header?
Date: Tue, 19 Aug 1997 19:00:07 -0000	[thread overview]
Message-ID: <m0x0seU-0004ecC@ocean.lucon.org> (raw)
Message-ID: <19970819190007.5z5Rg4ggFfBSezqvTx23GEXNJyTuEwcLcBi2X6LNIdw@z> (raw)
In-Reply-To: Unique SMTP From header?

This is a multi-part message in MIME format.
--------------34E1C86DEF52D15062591CA0
Content-Type: text/plain; charset=us-ascii
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Transfer-Encoding: 7bit

Peter Seebach wrote:

> >Is it possible to set the envelope sender of all mail coming from the
> list
> >to some unique address, e.g. egcs-errors@cygnus.com, or something
> similar?
> >It would make sorting with procmail much easier.
>
> Seconded!
>
> I hope in the near future to be able to sort my mail, and I am hoping
> for
> all of my mailing lists to be easily identifiable.
>
> -s

Isn't the To: egcs@cygnus.com unique enough?
Of course, it might appear in a CC: line.
    -Dan

--
Dan A. Dickey  http://www.transition.com/
mailto:ddickey@transition.com


--------------34E1C86DEF52D15062591CA0
Content-Type: text/x-vcard; charset=us-ascii; name="vcard.vcf"
Content-Transfer-Encoding: 7bit
Content-Description: Card for Dan Dickey
Content-Disposition: attachment; filename="vcard.vcf"

begin:          vcard
fn:             Dan Dickey
n:              Dickey;Dan
org:            Transition Networks, Inc.
adr:            6475 City West Parkway;;;Eden Prairie;MN;55344;USA
email;internet: ddickey@transition.com
title:          Sr. Software Engineer
tel;work:       612-941-7600
tel;fax:        612-941-2322
x-mozilla-cpt:  ;0
x-mozilla-html: TRUE
end:            vcard


--------------34E1C86DEF52D15062591CA0--

             reply	other threads:[~1997-08-19 19:00 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1997-08-19 19:00 Jeffrey A Law [this message]
1997-08-19 19:00 ` A prototype patch for tree.h/tree.def/calls.c H.J. Lu
1997-08-19 19:00 ` Jeffrey A Law
1997-08-19 19:00 ` Unique SMTP From header? Dan A. Dickey
  -- strict thread matches above, loose matches on Subject: below --
1997-09-04 11:27 Some Haifa scheduler bugs meissner
     [not found] <Pine.SOL.3.90.970826141030.2901K-100000@maigret.informatik.rwth-aachen.de>
1997-09-01 20:42 ` Jeffrey A Law
     [not found] <Pine.SOL.3.90.970826140826.2901J-100000@maigret.informatik.rwth-aachen.de>
1997-09-01 20:33 ` Jeffrey A Law
1997-09-03  9:30   ` Bernd Schmidt
1997-09-03  9:37     ` Jeffrey A Law
1997-09-03  9:44       ` Bernd Schmidt
1997-09-03 10:07         ` Jeffrey A Law
1997-09-05  7:15           ` Bernd Schmidt
1997-09-05  7:55             ` Jeffrey A Law
1997-09-05  8:33             ` Ian Lance Taylor
1997-09-03 11:58       ` Jim Wilson
1997-09-03 11:39     ` Paul Koning
1997-09-03 11:50       ` David Edelsohn
1997-09-03 13:13       ` Richard Henderson
1997-09-03 13:19       ` Jeffrey A Law
1997-09-04  9:33         ` Craig Burley
1997-09-04 11:12           ` Jeffrey A Law
1997-09-04 11:33             ` David S. Miller
1997-09-04 14:38               ` David Edelsohn
1997-08-26 14:34 Bernd Schmidt
1997-08-22 13:53 Building of generated parser files Andreas Schwab
1997-08-22 15:02 ` Some Haifa scheduler bugs Jeffrey A Law
1997-08-22 15:24 ` Jeffrey A Law
1997-08-22 10:48 Building of generated parser files Niklas Hallqvist
1997-08-22 13:28 ` Some Haifa scheduler bugs Bernd Schmidt
1997-08-21 16:51 Problems on PowerPC David Edelsohn
1997-08-21 17:43 ` Some Haifa scheduler bugs Jeffrey A Law
1997-08-21 15:20 egcs repository Joel Sherrill
1997-08-21 15:47 ` Some Haifa scheduler bugs Bernd Schmidt
1997-08-19 17:54 Jeffrey A Law
1997-08-19  7:36 egcs: A new compiler project to merge the existing GCC forks (fwd) Robert Wilhelm
1997-08-19  9:34 ` Some Haifa scheduler bugs Bernd Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m0x0seU-0004ecC@ocean.lucon.org \
    --to=law@hurl.cygnus.com \
    --cc=egcs@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).