Re: A prototype patch for tree.h/tree.def/calls.c

[H.J. Lu <hjl@lucon.org>]

> 
>   In message <m0x0r16-0004edC@ocean.lucon.org>you write:
>   > > 
>   > >   In message <m0x0opG-0004edC@ocean.lucon.org>you write:
>   > >   > I have some problem s with my emails for the past few days. I may
>   > >   > have lost some. I only remember your comments on BUFSIZ being a macro
>   > ,
>   > >   > which turned out ok. What else?
>   > > Relatively minor stuff.
>   > > 
>   > > For this pass #if 0 the prototypes for xmalloc and related funtions;
>   > > once the bulk of the prototypes are in, please submit a separate
>   > > patch to enable prototyping of xmalloc and related functions.
>   > 
>   > On my machine, they are enabled.
> Please disable them for the patch.

It is disabled in all my patches. Please double check it.

> 
>   > That is exactly the problem with size_t. How can you be
>   > sure size_t is available on all systems when xmalloc ()
>   > is used? many xmalloc () in gcc use unsigned. I think
>   > it makes some senses.
> NO!  You simply can't change from size_t to unsigned, that's
> just plain wrong.

Please check all xmalloc definitions in egcs. Many of
them use unsigned.

> 
> Seems to me the right way to do this is with autoconf.
> 

I don't know any scheme which will work on all systems.

> 
>   > I have spent weeks on it. I am afraid I may make some
>   > stupid mistakes if I try to reformat it. After all,
>   > those prototypes are mainly for compiler. Please feel
>   > free to reformat it. Thanks.
> Then they're not likely to go in anytime soon.  I don't have the
> time to spend reformatting all your changes.
> 
>   > Here is what I have in my i386.h:
>   > 
>   > #define NEED_enum_rtx_code    
>   > #include "rtl.def"                
>   > #undef NEED_enum_rtx_code                                        
>   > #define NEED_enum_machine_mode                                     
>   > #include "machmode.def"               
>   > #undef NEED_enum_machine_mode                       
> I had a feeling you'd done something like this -- let's punt this
> for now until we can come up with something better.
> 

I have tried many different ways. That is the smallest, working
scheme. Does anyone have a better one which doesn't involve
massive changes?

> 
> So, it seems to me you need to do 3 things:
> 
>   * #if0 the xmalloc and friends prototypes.

It is not an issue to begin with.

>   * Don't mess with the enum rtx_code and enum tree_code stuff
>     right now.

Why, my change is small and working. It is very trivial
to back it out. When will the greatest one be found anyway?

>   * Do some minor formatting.

I am talking about over 5,000 lines of code. I don't feel like
to reformat it for something that no compilers even care. I think
protoptype is for compilers, not for human. But, again, feel free
to reformat it.

> 
> We're not talking about a lot of work that you'd need to do to
> get your patches installed immediately.
> 


-- 
H.J. Lu (hjl@gnu.ai.mit.edu)