From: hjl@lucon.org (H.J. Lu)
To: khan@xraylith.wisc.edu (Mumit Khan)
Cc: egcs@cygnus.com
Subject: Re: (1.0.2) std/bastring.h change -- Why add std/bastring.cc?
Date: Wed, 18 Feb 1998 14:54:00 -0000 [thread overview]
Message-ID: <m0y5H2p-00058KC@ocean.lucon.org> (raw)
In-Reply-To: <9802180511.AA18538@modi.xraylith.wisc.edu>
>
> Jason Merrill <jason@cygnus.com> writes:
> >
> > I suppose we should resurrect sinst.h.
> >
>
> Please do. I'd rather not see 1.0.2 released with the current scheme.
> I just built a moderately large project hat went up 20% in disk usage
> and also about ~15% in link time on ELF, and on sparc-sunso4.1.3, the
> results were much worse both in time and space.
>
Here is the patch. I have another patch for STL to deal with
thread-safe on glibc 2.
--
H.J. Lu (hjl@gnu.org)
----
Wed Feb 18 07:33:14 1998 H.J. Lu (hjl@gnu.org)
* std/bastring.h: Don't include <std/bastring.cc>.
* std/bastring.cc: Include <cstddef> and <std/bastring.h>.
* sinst.cc: Just include <std/bastring.cc>.
--- ../../../import/egcs/libstdc++/std/bastring.h Tue Feb 10 08:07:33 1998
+++ std/bastring.h Wed Feb 18 12:29:55 1998
@@ -607,6 +607,4 @@
} // extern "C++"
-#include <std/bastring.cc>
-
#endif
--- ../../../import/egcs/libstdc++/std/bastring.cc Tue Feb 10 08:07:32 1998
+++ std/bastring.cc Wed Feb 18 12:29:55 1998
@@ -25,6 +25,9 @@
// Written by Jason Merrill based upon the specification by Takanori Adachi
// in ANSI X3J16/94-0013R2.
+#include <cstddef>
+#include <std/bastring.h>
+
extern "C++" {
template <class charT, class traits, class Allocator>
inline void * basic_string <charT, traits, Allocator>::Rep::
--- ../../../import/egcs/libstdc++/sinst.cc Tue Feb 10 08:07:30 1998
+++ sinst.cc Wed Feb 18 12:29:55 1998
@@ -33,7 +33,7 @@
#endif
#endif
-#include <string>
+#include <std/bastring.cc>
#ifdef C
typedef char c;
next prev parent reply other threads:[~1998-02-18 14:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-02-17 9:51 Mumit Khan
1998-02-17 10:40 ` Joe Buck
[not found] ` <199802171840.KAA06006.cygnus.egcs@atrus.synopsys.com>
1998-02-17 13:54 ` Jason Merrill
1998-02-17 15:16 ` H.J. Lu
1998-02-17 23:59 ` Mumit Khan
1998-02-18 14:54 ` A STL patch for egcs 1.0.2 H.J. Lu
1998-02-18 14:54 ` H.J. Lu [this message]
[not found] ` <m0y5H2p-00058KC.cygnus.egcs@ocean.lucon.org>
1998-02-19 10:45 ` (1.0.2) std/bastring.h change -- Why add std/bastring.cc? Jason Merrill
[not found] ` <m0y5H5T-00058KC.cygnus.egcs@ocean.lucon.org>
1998-02-19 10:47 ` A STL patch for egcs 1.0.2 Jason Merrill
1998-02-19 10:47 ` H.J. Lu
1998-02-19 12:42 ` Jason Merrill
1998-02-20 12:26 ` H.J. Lu
1998-02-20 12:26 ` Jason Merrill
1998-02-20 12:26 ` H.J. Lu
1998-02-20 11:09 ` Jason Merrill
1998-02-19 14:09 ` Ulrich Drepper
1998-02-22 16:39 ` Jeffrey A Law
1998-02-23 11:00 ` H.J. Lu
1998-02-23 9:19 ` Jeffrey A Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m0y5H2p-00058KC@ocean.lucon.org \
--to=hjl@lucon.org \
--cc=egcs@cygnus.com \
--cc=khan@xraylith.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).