From: hjl@lucon.org (H.J. Lu)
To: mmitchell@usa.net
Cc: egcs@cygnus.com
Subject: Re: An x86 patch for egcs
Date: Fri, 13 Mar 1998 18:29:00 -0000 [thread overview]
Message-ID: <m0yDbGw-00058fC@ocean.lucon.org> (raw)
In-Reply-To: <smtp.earthlink.net>
> This kind of code duplication is a pet peeve of mine; it makes it much
> harder to maintain software, especially software as complex as gcc.
> In general, if you had to change something in several places, then
> there should have been some kind of abstraction (e.g. a macro or a
> function) that would have allowed you to change something in only one
> place. That might be the fault of the previous author, but it's up to
> us, the current authors, to correct these defects.
>
Good suggestion. That is also my motivation to cleanup gen*.c. But my
gen*.c patch went nowhere. In the meantime, I have to keep updating my
patch.
I didn't write the original code. I just want to keep my change to
minimum. Otherwise, it will be a nightmare for me to create a patch
against the egcs CVS since my source tree is quite different from the
official one, especially the 386 backend. Currently my diff against
the egcs CVS is more than 6,000 lines.
BTW, I will see what I can do. There are many more PPro bugs in egcs.
H.J.
next prev parent reply other threads:[~1998-03-13 18:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-03-13 18:47 Mark Mitchell
[not found] ` <smtp.earthlink.net>
1998-03-13 18:29 ` H.J. Lu [this message]
1998-03-18 16:14 ` PATCH: add semantics.c Mark Mitchell
1998-03-19 21:47 ` PATCH for Re: cp/semantics.c is broken Mark Mitchell
1998-03-23 15:35 ` PATCH for Re: egcs-1.0.2, egcs-980315 and templates Andrew Pollard
1998-03-23 19:24 ` Mark Mitchell
-- strict thread matches above, loose matches on Subject: below --
1998-03-19 12:55 cp/semantics.c is broken H.J. Lu
1998-03-19 12:55 egcs-1.0.2, egcs-980315 and templates Andrew Pollard
1998-03-12 17:24 An x86 patch for egcs H.J. Lu
1998-03-16 19:46 ` Jim Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m0yDbGw-00058fC@ocean.lucon.org \
--to=hjl@lucon.org \
--cc=egcs@cygnus.com \
--cc=mmitchell@usa.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).