From: hjl@lucon.org (H.J. Lu)
To: law@cygnus.com
Cc: florian@suse.de, paubert@iram.es, egcs@cygnus.com
Subject: Re: egcs-problem 1.0.2
Date: Sun, 05 Apr 1998 21:29:00 -0000 [thread overview]
Message-ID: <m0yLuSz-00058iC@ocean.lucon.org> (raw)
In-Reply-To: <17575.891801698@hurl.cygnus.com>
> This is the "linux asm" problem that I haven't been able to look at
> for the last month or so due to personal and company commitments.
>
> Basically there's a couple problems:
>
> * The linux x86 asm for strstr is totally bogus.
Does the code below make sense?
>
> * GCC does not issue a warning/error when it encouters the bogus
> asm and instead generates incorrect code.
Agreed. I don't think it is too hard to issue an error.
Thanks.
--
H.J. Lu (hjl@gnu.org)
----
extern inline char * strstr(const char * cs,const char * ct)
{
register char * __res;
__asm__ __volatile__(
"cld\n\t" \
"movl %4,%%edi\n\t"
"repne\n\t"
"scasb\n\t"
"notl %%ecx\n\t"
"decl %%ecx\n\t"
"movl %%ecx,%%edx\n"
"1:\tmovl %4,%%edi\n\t"
"movl %%esi,%%eax\n\t"
"movl %%edx,%%ecx\n\t"
"repe\n\t"
"cmpsb\n\t"
"je 2f\n\t"
"xchgl %%eax,%%esi\n\t"
"incl %%esi\n\t"
"cmpb $0,-1(%%eax)\n\t"
"jne 1b\n\t"
"xorl %%eax,%%eax\n\t"
"2:"
:"=a" (__res):"0" (0),"c" (0xffffffff),"S" (cs),"m" (ct)
:"cx","dx","di","si");
return __res;
}
int count_substring_matches(char **haystacks, char **needles)
{
int hits=0, i, j;
for(i=0; haystacks[i]; i++) {
for(j=0; needles[j]; j++) {
if (strstr(haystacks[i], needles[j])) hits++;
}
}
return hits;
}
main ()
{
char * haystacks [] = {"foobar", 0};
char * needles [] = {"foo", 0};
if (count_substring_matches (haystacks, needles ) != 1)
abort ();
return 0;
}
next prev parent reply other threads:[~1998-04-05 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <19980331132837.33334@knorke.saar.de>
1998-04-04 20:05 ` H.J. Lu
1998-04-05 21:29 ` Jeffrey A Law
1998-04-05 21:29 ` H.J. Lu [this message]
1998-04-05 17:27 ` Jeffrey A Law
1998-04-05 17:27 ` H.J. Lu
1998-04-05 21:29 ` Jeffrey A Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m0yLuSz-00058iC@ocean.lucon.org \
--to=hjl@lucon.org \
--cc=egcs@cygnus.com \
--cc=florian@suse.de \
--cc=law@cygnus.com \
--cc=paubert@iram.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).