From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19047 invoked by alias); 9 Jun 2008 23:28:52 -0000 Received: (qmail 19039 invoked by uid 22791); 9 Jun 2008 23:28:51 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 09 Jun 2008 23:28:32 +0000 Received: from zps19.corp.google.com (zps19.corp.google.com [172.25.146.19]) by smtp-out.google.com with ESMTP id m59NSAqI016147; Tue, 10 Jun 2008 00:28:11 +0100 Received: from smtp.corp.google.com (spacemonkey1.corp.google.com [192.168.120.115]) by zps19.corp.google.com with ESMTP id m59NS93G010650 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 9 Jun 2008 16:28:10 -0700 Received: from localhost.localdomain.google.com (adsl-71-133-8-30.dsl.pltn13.pacbell.net [71.133.8.30]) (authenticated bits=0) by smtp.corp.google.com (8.13.8/8.13.8) with ESMTP id m59NOxdE006577 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 9 Jun 2008 16:25:00 -0700 To: Joern Rennecke Cc: "Kaveh R. GHAZI" , gcc@gcc.gnu.org Subject: Re: constified note_stores References: <20080609224328.GK32358@elsdt-razorfish.arc.com> From: Ian Lance Taylor Date: Mon, 09 Jun 2008 23:28:00 -0000 In-Reply-To: <20080609224328.GK32358@elsdt-razorfish.arc.com> (Joern Rennecke's message of "Mon\, 9 Jun 2008 23\:43\:28 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2008-06/txt/msg00207.txt.bz2 Joern Rennecke writes: > I have been using note_stores to modify selected assignments. Now when I > try to move this code to gcc 4.4, I find that I get a warning because > my walker function takes a non-const rtx - and if I make it take a const rtx, > there will be a warning somewhere inside because there is a code path > where a SET_SRC is modified. > data is in use to point to a libiberty hash table. > > So, am I supposed to ignore the warning? > Roll my own copy of the original note_stores? > Resurrect the original note_stores in rtlanal.c (by whatever name)? Use CONST_CAST_RTX where necessary. Ian