From: Ian Lance Taylor <iant@google.com>
To: "Doug Gregor" <doug.gregor@gmail.com>
Cc: jklowden@freetds.org, gcc-patches@gcc.gnu.org, gcc@gnu.org
Subject: Re: -Wparentheses lumps too much together
Date: Sat, 12 Jan 2008 03:48:00 -0000 [thread overview]
Message-ID: <m3hchj3gd0.fsf@localhost.localdomain> (raw)
In-Reply-To: <24b520d20801111427r6081fec6k6a4a513e5022c492@mail.gmail.com>
"Doug Gregor" <doug.gregor@gmail.com> writes:
> To make this discussion a bit more concrete, the attached patch
> removes this particular warning from -Wparentheses and puts it into a
> new warning, -Wprecedence, that is not enabled by -Wall. This is
> slightly more fine-grained than what -Wparentheses does now. Opinions?
Personally, I think it should stay in -Wall. But I'm willing to hear
other opinions.
> @@ -6430,7 +6430,7 @@ convert_for_assignment (tree type, tree
>
> /* If -Wparentheses, warn about a = b = c when a has type bool and b
> does not. */
> - if (warn_parentheses
> + if ((warn_parentheses || warn_precedence)
> && type == boolean_type_node
> && TREE_CODE (rhs) == MODIFY_EXPR
> && !TREE_NO_WARNING (rhs)
I believe this case (in cp/typeck.c) should only check
warn_parentheses, not warn_precedence.
I'm inclined to approve this if -Wprecedence stays in -Wall, but I'd
like to hear if anybody else has anything to say.
Ian
next prev parent reply other threads:[~2008-01-12 2:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 20:07 jklowden
2007-12-19 20:14 ` Doug Gregor
2007-12-19 20:39 ` Ismail Dönmez
2007-12-19 20:15 ` Daniel Jacobowitz
2007-12-19 23:11 ` Ian Lance Taylor
2007-12-20 6:08 ` James K. Lowden
2007-12-20 16:41 ` Paul Brook
2007-12-21 20:19 ` Ross Smith
2008-01-11 7:34 ` Rehno Lindeque
2008-01-11 17:00 ` Joe Buck
2008-01-11 17:05 ` Robert Dewar
2008-01-11 23:26 ` Ian Lance Taylor
2008-01-12 0:50 ` Joe Buck
2007-12-20 18:01 ` Ian Lance Taylor
2007-12-21 5:28 ` James K. Lowden
2007-12-21 9:27 ` Ralf Wildenhues
2007-12-21 17:16 ` NightStrike
2008-01-11 22:44 ` Doug Gregor
2008-01-12 3:48 ` Ian Lance Taylor [this message]
2008-01-12 10:16 ` Andreas Schwab
2008-01-12 11:23 ` Paolo Bonzini
2008-01-13 16:03 ` Gabriel Dos Reis
2008-03-10 17:25 Derek M Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hchj3gd0.fsf@localhost.localdomain \
--to=iant@google.com \
--cc=doug.gregor@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gnu.org \
--cc=jklowden@freetds.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).