From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28265 invoked by alias); 19 Dec 2007 22:59:29 -0000 Received: (qmail 28244 invoked by uid 22791); 19 Dec 2007 22:59:28 -0000 X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Dec 2007 22:59:21 +0000 Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J57sl-0002Mb-QZ for gcc@gnu.org; Wed, 19 Dec 2007 17:59:19 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1J57sj-0006w4-MO for gcc@gnu.org; Wed, 19 Dec 2007 17:59:19 -0500 Received: from smtp-out.google.com ([216.239.33.17]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J57sj-0006uM-9W for gcc@gnu.org; Wed, 19 Dec 2007 17:59:17 -0500 Received: from zps18.corp.google.com (zps18.corp.google.com [172.25.146.18]) by smtp-out.google.com with ESMTP id lBJMwNLf012809; Wed, 19 Dec 2007 22:58:23 GMT Received: from localhost.localdomain.google.com (dhcp-172-18-119-235.corp.google.com [172.18.119.235]) (authenticated bits=0) by zps18.corp.google.com with ESMTP id lBJMwMEb014976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 19 Dec 2007 14:58:22 -0800 To: jklowden@freetds.org Cc: gcc@gnu.org Subject: Re: -Wparentheses lumps too much together References: <20071219200235.GA21525@oak.schemamania.org> From: Ian Lance Taylor Date: Wed, 19 Dec 2007 23:11:00 -0000 In-Reply-To: <20071219200235.GA21525@oak.schemamania.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2007-12/txt/msg00606.txt.bz2 jklowden@freetds.org writes: > Much as I'm a fan of the GCC and rely on -Wall, I would like to suggest > to you that -Wparentheses should be split up, and things it checks/suggests > be moved out of -Wall. If this is not the right forum or if you'd rather > see this as a bug report, I'm happy to go where I'm pointed. I have no objection to splitting -Wparentheses into separate warnings controlled by separate options. > My specific candidate for exclusion from -Wall is this one: > > if (a && b || c && d) > > which yields (as you know) advice to parenthesize the two && pairs. That particular warning happened to find dozens of real errors when I ran it over a large code base. It may be noise for you, but I know from personal experience that it is very useful. Ian