From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14824 invoked by alias); 11 Jan 2008 23:25:15 -0000 Received: (qmail 14809 invoked by uid 22791); 11 Jan 2008 23:25:14 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 11 Jan 2008 23:24:56 +0000 Received: from zps75.corp.google.com (zps75.corp.google.com [172.25.146.75]) by smtp-out.google.com with ESMTP id m0BNOoKp004190; Fri, 11 Jan 2008 23:24:51 GMT Received: from localhost.localdomain.google.com (dhcp-172-18-119-235.corp.google.com [172.18.119.235]) (authenticated bits=0) by zps75.corp.google.com with ESMTP id m0BNOnYJ007704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 11 Jan 2008 15:24:49 -0800 To: Joe Buck Cc: Rehno Lindeque , Ross Smith , gcc@gcc.gnu.org Subject: Re: -Wparentheses lumps too much together References: <20071219200235.GA21525@oak.schemamania.org> <20071220005030.4971a442.jklowden@freetds.org> <200712201509.20582.paul@codesourcery.com> <476C1461.2050107@ihug.co.nz> <20080111165936.GB31668@synopsys.com> From: Ian Lance Taylor Date: Fri, 11 Jan 2008 23:26:00 -0000 In-Reply-To: <20080111165936.GB31668@synopsys.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2008-01/txt/msg00158.txt.bz2 Joe Buck writes: > A warning that flagged code like > > if (c1 || c2 && c3) > ... > > would swamp users in warnings, since this kind of code is extremely > common, and this isn't the kind of thing that anyone who's not a total C > beginner has trouble with. That is what -Wparentheses does today. I think it's a good thing, because I've seen it catch coding errors in real code. Ian