public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <ian@wasabisystems.com>
To: geoffk@apple.com, gcc@gcc.gnu.org
Cc: gcc-bugzilla@gcc.gnu.org
Subject: Re: [Bug pch/14400] Cannot compile qt-x11-free-3.3.0
Date: Fri, 02 Apr 2004 15:18:00 -0000	[thread overview]
Message-ID: <m3zn9ue7dt.fsf@gossamer.airs.com> (raw)
In-Reply-To: <20040401011718.8875.qmail@sources.redhat.com>

"geoffk at apple dot com" <gcc-bugzilla@gcc.gnu.org> writes:

> On Mar 29, 2004, at 11:06 PM, Ian Lance Taylor wrote:

> > PR 14206 is fixed on mainline by RTH's patch.  For 3.4 I put in a doc
> > fix.

> I've now caught up enough that I read RTH's patch (I've been on 
> vacation).  Yes, that patch should fix this problem too.  I'd suggest 
> backporting it to 3.4.

We can do that.  However, I am still troubled by the fact that the
default fallback for gt_pch_get_address/gt_pch_use_address is
unreliable.  RTH's patch may well fix the problem on GNU/Linux for all
but strange cases.  But it seems to me that with that patch PCH will
work reasonably on GNU/Linux and on Darwin, but will not work reliably
on any other system.

That is, I don't think that any system can reliably use
mmap_gt_pch_get_address/mmap_gt_pch_use_address, although they are the
default functions on a system which supports mmap.

Is it better to have PCH which unpredictably fails or PCH which
reliably fails?  Right now, in mainline, I think we have the former,
except on GNU/Linux and Darwin.

Ian

  parent reply	other threads:[~2004-04-02 15:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20040303083528.14400.schmid@snake.iap.physik.tu-darmstadt.de>
     [not found] ` <20040330014217.28608.qmail@sources.redhat.com>
2004-03-30 14:02   ` Ian Lance Taylor
2004-04-01  1:17     ` Geoff Keating
     [not found] ` <20040401011718.8875.qmail@sources.redhat.com>
2004-04-02 15:18   ` Ian Lance Taylor [this message]
2004-04-02 19:16     ` Geoffrey Keating
2004-04-04  3:38       ` Ian Lance Taylor
2004-04-05 20:54         ` Mike Stump
2004-04-05 22:50         ` Geoff Keating
2004-04-06  0:39           ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3zn9ue7dt.fsf@gossamer.airs.com \
    --to=ian@wasabisystems.com \
    --cc=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc@gcc.gnu.org \
    --cc=geoffk@apple.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).