From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29624 invoked by alias); 2 Apr 2004 15:18:00 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 29598 invoked from network); 2 Apr 2004 15:17:58 -0000 Received: from unknown (HELO yosemite.airs.com) (209.128.65.135) by sources.redhat.com with SMTP; 2 Apr 2004 15:17:58 -0000 Received: (qmail 5056 invoked by uid 10); 2 Apr 2004 15:17:58 -0000 Received: (qmail 9881 invoked by uid 500); 2 Apr 2004 15:17:50 -0000 From: Ian Lance Taylor To: geoffk@apple.com, gcc@gcc.gnu.org Cc: gcc-bugzilla@gcc.gnu.org Subject: Re: [Bug pch/14400] Cannot compile qt-x11-free-3.3.0 References: <20040303083528.14400.schmid@snake.iap.physik.tu-darmstadt.de> <20040401011718.8875.qmail@sources.redhat.com> Date: Fri, 02 Apr 2004 15:18:00 -0000 In-Reply-To: <20040401011718.8875.qmail@sources.redhat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-04/txt/msg00110.txt.bz2 "geoffk at apple dot com" writes: > On Mar 29, 2004, at 11:06 PM, Ian Lance Taylor wrote: > > PR 14206 is fixed on mainline by RTH's patch. For 3.4 I put in a doc > > fix. > I've now caught up enough that I read RTH's patch (I've been on > vacation). Yes, that patch should fix this problem too. I'd suggest > backporting it to 3.4. We can do that. However, I am still troubled by the fact that the default fallback for gt_pch_get_address/gt_pch_use_address is unreliable. RTH's patch may well fix the problem on GNU/Linux for all but strange cases. But it seems to me that with that patch PCH will work reasonably on GNU/Linux and on Darwin, but will not work reliably on any other system. That is, I don't think that any system can reliably use mmap_gt_pch_get_address/mmap_gt_pch_use_address, although they are the default functions on a system which supports mmap. Is it better to have PCH which unpredictably fails or PCH which reliably fails? Right now, in mainline, I think we have the former, except on GNU/Linux and Darwin. Ian