Bootstrap with -Wmissing-prototypes doesn't work for C++

Bootstrap with -Wmissing-prototypes doesn't work for C++

[H.J. Lu]

Since -Wmissing-prototypes doesn't work for C++, using
C++ to bootstrap GCC makes -Wmissing-prototypes useless.
You will see the -Wmissing-prototypes message in stage 1,
but you won't see it in stage3 2/3.

-- 
H.J.

RE: Bootstrap with -Wmissing-prototypes doesn't work for C++

[Joe Buck]

I'm confused. Since C++ treats the lack of a prototype as a hard error, what does it mean to make -Wmissing-prototypes useless?

________________________________________
From: gcc-owner@gcc.gnu.org [gcc-owner@gcc.gnu.org] On Behalf Of H.J. Lu [hjl.tools@gmail.com]
Sent: Friday, August 19, 2011 9:36 AM
To: GCC Development
Subject: Bootstrap with -Wmissing-prototypes doesn't work for C++

Since -Wmissing-prototypes doesn't work for C++, using
C++ to bootstrap GCC makes -Wmissing-prototypes useless.
You will see the -Wmissing-prototypes message in stage 1,
but you won't see it in stage3 2/3.

--
H.J.

Re: Bootstrap with -Wmissing-prototypes doesn't work for C++

[H.J. Lu]

[hjl@gnu-33 gcc]$ cat x.c
int
foo (int x)
{
  return x;
}
[hjl@gnu-33 gcc]$ ./xgcc -B./ -S -O -Wmissing-prototypes x.c
x.c:2:1: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes]
[hjl@gnu-33 gcc]$ ./g++ -B./ -S -O -Wmissing-prototypes x.c
cc1plus: warning: command line option ‘-Wmissing-prototypes’ is valid
for Ada/AdaWhy/C/ObjC but not for C++ [enabled by default]
[hjl@gnu-33 gcc]$ ./g++ -B./ -S -O x.c
[hjl@gnu-33 gcc]$

Is this a bug?

On Fri, Aug 19, 2011 at 12:24 PM, Joe Buck <Joe.Buck@synopsys.com> wrote:
> I'm confused. Since C++ treats the lack of a prototype as a hard error, what does it mean to make -Wmissing-prototypes useless?
>
> ________________________________________
> From: gcc-owner@gcc.gnu.org [gcc-owner@gcc.gnu.org] On Behalf Of H.J. Lu [hjl.tools@gmail.com]
> Sent: Friday, August 19, 2011 9:36 AM
> To: GCC Development
> Subject: Bootstrap with -Wmissing-prototypes doesn't work for C++
>
> Since -Wmissing-prototypes doesn't work for C++, using
> C++ to bootstrap GCC makes -Wmissing-prototypes useless.
> You will see the -Wmissing-prototypes message in stage 1,
> but you won't see it in stage3 2/3.
>
> --
> H.J.



-- 
H.J.

RE: Bootstrap with -Wmissing-prototypes doesn't work for C++

[Paul_Koning]

I think the point is that the effect of -Wmissing-prototypes is always enabled in C++, so that switch is rejected.  The solution would seem to be to remove that switch from the command line if C++ is used to build; that will produce the intended result.

	paul

-----Original Message-----
From: gcc-owner@gcc.gnu.org [mailto:gcc-owner@gcc.gnu.org] On Behalf Of H.J. Lu
Sent: Friday, August 19, 2011 3:34 PM
To: Joe Buck
Cc: GCC Development
Subject: Re: Bootstrap with -Wmissing-prototypes doesn't work for C++

[hjl@gnu-33 gcc]$ cat x.c
int
foo (int x)
{
  return x;
}
[hjl@gnu-33 gcc]$ ./xgcc -B./ -S -O -Wmissing-prototypes x.c
x.c:2:1: warning: no previous prototype for 'foo' [-Wmissing-prototypes]
[hjl@gnu-33 gcc]$ ./g++ -B./ -S -O -Wmissing-prototypes x.c
cc1plus: warning: command line option '-Wmissing-prototypes' is valid for Ada/AdaWhy/C/ObjC but not for C++ [enabled by default]
[hjl@gnu-33 gcc]$ ./g++ -B./ -S -O x.c
[hjl@gnu-33 gcc]$

Is this a bug?

On Fri, Aug 19, 2011 at 12:24 PM, Joe Buck <Joe.Buck@synopsys.com> wrote:
> I'm confused. Since C++ treats the lack of a prototype as a hard error, what does it mean to make -Wmissing-prototypes useless?
>
> ________________________________________
> From: gcc-owner@gcc.gnu.org [gcc-owner@gcc.gnu.org] On Behalf Of H.J. 
> Lu [hjl.tools@gmail.com]
> Sent: Friday, August 19, 2011 9:36 AM
> To: GCC Development
> Subject: Bootstrap with -Wmissing-prototypes doesn't work for C++
>
> Since -Wmissing-prototypes doesn't work for C++, using
> C++ to bootstrap GCC makes -Wmissing-prototypes useless.
> You will see the -Wmissing-prototypes message in stage 1, but you 
> won't see it in stage3 2/3.
>
> --
> H.J.



--
H.J.

Re: Bootstrap with -Wmissing-prototypes doesn't work for C++

[H.J. Lu]

On Fri, Aug 19, 2011 at 1:35 PM,  <Paul_Koning@dell.com> wrote:
> I think the point is that the effect of -Wmissing-prototypes is always enabled in C++, so that switch is rejected.  The solution would seem to be to remove that switch from the command line if C++ is used to build; that will produce the intended result.

G++ doesn't give a warning at all:

[hjl@gnu-33 gcc]$ cat x.c
int
foo (int x)
{
  return x;
}
[hjl@gnu-33 gcc]$ ./g++ -B./ -Wall -S -O x.c
[hjl@gnu-33 gcc]$


>        paul
>
> -----Original Message-----
> From: gcc-owner@gcc.gnu.org [mailto:gcc-owner@gcc.gnu.org] On Behalf Of H.J. Lu
> Sent: Friday, August 19, 2011 3:34 PM
> To: Joe Buck
> Cc: GCC Development
> Subject: Re: Bootstrap with -Wmissing-prototypes doesn't work for C++
>
> [hjl@gnu-33 gcc]$ cat x.c
> int
> foo (int x)
> {
>  return x;
> }
> [hjl@gnu-33 gcc]$ ./xgcc -B./ -S -O -Wmissing-prototypes x.c
> x.c:2:1: warning: no previous prototype for 'foo' [-Wmissing-prototypes]
> [hjl@gnu-33 gcc]$ ./g++ -B./ -S -O -Wmissing-prototypes x.c
> cc1plus: warning: command line option '-Wmissing-prototypes' is valid for Ada/AdaWhy/C/ObjC but not for C++ [enabled by default]
> [hjl@gnu-33 gcc]$ ./g++ -B./ -S -O x.c
> [hjl@gnu-33 gcc]$
>
> Is this a bug?
>
> On Fri, Aug 19, 2011 at 12:24 PM, Joe Buck <Joe.Buck@synopsys.com> wrote:
>> I'm confused. Since C++ treats the lack of a prototype as a hard error, what does it mean to make -Wmissing-prototypes useless?
>>
>> ________________________________________
>> From: gcc-owner@gcc.gnu.org [gcc-owner@gcc.gnu.org] On Behalf Of H.J.
>> Lu [hjl.tools@gmail.com]
>> Sent: Friday, August 19, 2011 9:36 AM
>> To: GCC Development
>> Subject: Bootstrap with -Wmissing-prototypes doesn't work for C++
>>
>> Since -Wmissing-prototypes doesn't work for C++, using
>> C++ to bootstrap GCC makes -Wmissing-prototypes useless.
>> You will see the -Wmissing-prototypes message in stage 1, but you
>> won't see it in stage3 2/3.
>>
>> --
>> H.J.
>
>
>
> --
> H.J.
>



-- 
H.J.

Re: Bootstrap with -Wmissing-prototypes doesn't work for C++

[Ian Lance Taylor]

"H.J. Lu" <hjl.tools@gmail.com> writes:

> [hjl@gnu-33 gcc]$ cat x.c
> int
> foo (int x)
> {
>   return x;
> }
> [hjl@gnu-33 gcc]$ ./xgcc -B./ -S -O -Wmissing-prototypes x.c
> x.c:2:1: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes]
> [hjl@gnu-33 gcc]$ ./g++ -B./ -S -O -Wmissing-prototypes x.c
> cc1plus: warning: command line option ‘-Wmissing-prototypes’ is valid
> for Ada/AdaWhy/C/ObjC but not for C++ [enabled by default]
> [hjl@gnu-33 gcc]$ ./g++ -B./ -S -O x.c
> [hjl@gnu-33 gcc]$
>
> Is this a bug?

This is a minor missing feature, yes.  We ought to implement
-Wmissing-prototypes for C++.

Ian

Re: Bootstrap with -Wmissing-prototypes doesn't work for C++

[H.J. Lu]

On Fri, Aug 19, 2011 at 2:45 PM, Ian Lance Taylor <iant@google.com> wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
>> [hjl@gnu-33 gcc]$ cat x.c
>> int
>> foo (int x)
>> {
>>   return x;
>> }
>> [hjl@gnu-33 gcc]$ ./xgcc -B./ -S -O -Wmissing-prototypes x.c
>> x.c:2:1: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes]
>> [hjl@gnu-33 gcc]$ ./g++ -B./ -S -O -Wmissing-prototypes x.c
>> cc1plus: warning: command line option ‘-Wmissing-prototypes’ is valid
>> for Ada/AdaWhy/C/ObjC but not for C++ [enabled by default]
>> [hjl@gnu-33 gcc]$ ./g++ -B./ -S -O x.c
>> [hjl@gnu-33 gcc]$
>>
>> Is this a bug?
>
> This is a minor missing feature, yes.  We ought to implement
> -Wmissing-prototypes for C++.
>

I opened:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50134

-- 
H.J.

Re: Bootstrap with -Wmissing-prototypes doesn't work for C++

[Gabriel Dos Reis]

On Fri, Aug 19, 2011 at 4:45 PM, Ian Lance Taylor <iant@google.com> wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
>> [hjl@gnu-33 gcc]$ cat x.c
>> int
>> foo (int x)
>> {
>>   return x;
>> }
>> [hjl@gnu-33 gcc]$ ./xgcc -B./ -S -O -Wmissing-prototypes x.c
>> x.c:2:1: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes]
>> [hjl@gnu-33 gcc]$ ./g++ -B./ -S -O -Wmissing-prototypes x.c
>> cc1plus: warning: command line option ‘-Wmissing-prototypes’ is valid
>> for Ada/AdaWhy/C/ObjC but not for C++ [enabled by default]
>> [hjl@gnu-33 gcc]$ ./g++ -B./ -S -O x.c
>> [hjl@gnu-33 gcc]$
>>
>> Is this a bug?
>
> This is a minor missing feature, yes.  We ought to implement
> -Wmissing-prototypes for C++.
>

what would it do?  There is no notion of `prototype' in C++ (as C
programmers understand it).
So, what would it mean to warn about something we can't take the
negation of? ;-)

-- Gaby

Re: Bootstrap with -Wmissing-prototypes doesn't work for C++

[Ian Lance Taylor]

Gabriel Dos Reis <gdr@integrable-solutions.net> writes:

> what would it do?  There is no notion of `prototype' in C++ (as C
> programmers understand it).
> So, what would it mean to warn about something we can't take the
> negation of? ;-)

-Wmissing-prototypes means that if the compiler sees a globally visible
function definition, it warns if no previous definition of the function
was seen.  This is a way of ensuring that the file which defines a
function #includes the header file which declares the function, thus
ensuring that the definition matches the declaration.  Although the name
is wrong for C++, the option is meaningful for C++ just as it is for C.

(I actually sent a patch implementing this option to RMS back when I was
first starting to work with gcc, although I think he rewrote it.)

Ian

Re: Bootstrap with -Wmissing-prototypes doesn't work for C++

[Gabriel Dos Reis]

On Fri, Aug 19, 2011 at 11:17 PM, Ian Lance Taylor <iant@google.com> wrote:
> Gabriel Dos Reis <gdr@integrable-solutions.net> writes:
>
>> what would it do?  There is no notion of `prototype' in C++ (as C
>> programmers understand it).
>> So, what would it mean to warn about something we can't take the
>> negation of? ;-)
>
> -Wmissing-prototypes means that if the compiler sees a globally visible
> function definition, it warns if no previous definition of the function
> was seen.  This is a way of ensuring that the file which defines a
> function #includes the header file which declares the function, thus
> ensuring that the definition matches the declaration.  Although the name
> is wrong for C++, the option is meaningful for C++ just as it is for C.

So that is -Wmissing-declaration if I understand correctly?

By "globally visible function definition" do you also include member functions?
That would be unusual.  I am also concerned that it would mean that a
non-member inline function would have to be declared first, as that is
not the case for
colloquial C++.

I understand what the `prototype' notion is immensely useful in C.  But the
problem it was designed to help mitigate has been cured long in C++, and I worry
that trying to placate that to modern C++ would lead to non-colloquial C++.

>
> (I actually sent a patch implementing this option to RMS back when I was
> first starting to work with gcc, although I think he rewrote it.)
>
> Ian
>

Re: Bootstrap with -Wmissing-prototypes doesn't work for C++

[Ian Lance Taylor]

Gabriel Dos Reis <gdr@integrable-solutions.net> writes:

> On Fri, Aug 19, 2011 at 11:17 PM, Ian Lance Taylor <iant@google.com> wrote:
>> Gabriel Dos Reis <gdr@integrable-solutions.net> writes:
>>
>>> what would it do?  There is no notion of `prototype' in C++ (as C
>>> programmers understand it).
>>> So, what would it mean to warn about something we can't take the
>>> negation of? ;-)
>>
>> -Wmissing-prototypes means that if the compiler sees a globally visible
>> function definition, it warns if no previous definition of the function
>> was seen.  This is a way of ensuring that the file which defines a
>> function #includes the header file which declares the function, thus
>> ensuring that the definition matches the declaration.  Although the name
>> is wrong for C++, the option is meaningful for C++ just as it is for C.
>
> So that is -Wmissing-declaration if I understand correctly?

Hmmm, you're right, -Wmissing-declarations seems to be equivalent to
-Wmissing-prototypes when using C++.  Sorry I missed that.

Ian

Re: Bootstrap with -Wmissing-prototypes doesn't work for C++

[Joe Buck]

On Sat, Aug 20, 2011 at 07:20:41AM -0700, Ian Lance Taylor wrote:
> Hmmm, you're right, -Wmissing-declarations seems to be equivalent to
> -Wmissing-prototypes when using C++.  Sorry I missed that.

Then it would seem that HJ's issue could be fixed by treating
-Wmissing-prototypes as a synonym for -Wmissing-declarations when building
C++.

RE: Bootstrap with -Wmissing-prototypes doesn't work for C++

[Marc Glisse]

On Fri, 19 Aug 2011, Joe Buck wrote:

> I'm confused. Since C++ treats the lack of a prototype as a hard error, 
> what does it mean to make -Wmissing-prototypes useless?

-Wmissing-prototype looks very similar to -Wmissing-declarations (which is 
supported in C++ but documented as C/objC only). It requires that you 
first have:

int f(int);
and only then:
int f(int){return 0;}

-- 
Marc Glisse