From: Ian Lance Taylor <iant@google.com>
To: Mohamed Shafi <shafitvm@gmail.com>
Cc: GCC <gcc@gcc.gnu.org>
Subject: Re: Typo in internals
Date: Fri, 23 Oct 2009 14:57:00 -0000 [thread overview]
Message-ID: <mcrpr8exjmi.fsf@dhcp-172-17-9-151.mtv.corp.google.com> (raw)
In-Reply-To: <ba0bd44d0910230033w29c36260rb33540df35341e5c@mail.gmail.com> (Mohamed Shafi's message of "Fri\, 23 Oct 2009 13\:03\:18 +0530")
Mohamed Shafi <shafitvm@gmail.com> writes:
> The internal doc says :
>
> — Target Hook: bool TARGET_CAN_INLINE_P (tree caller, tree callee)
>
> This target hook returns false if the caller function cannot
> inline callee, based on target specific information. By default,
> inlining is not allowed if the callee function has function specific
> target options and the caller does not use the same options.
>
>
> But looking in the sources i think this really should have been
> TARGET_OPTION_CAN_INLINE_P
This is fixed in the development sources:
2009-07-09 DJ Delorie <dj@redhat.com>
* targhooks.c (default_target_can_inline_p): Rename from
default_target_option_can_inline_p.
* targhooks.h (default_target_can_inline_p): Likewise.
* target-def.h (TARGET_CAN_INLINE_P): Rename from
TARGET_OPTION_CAN_INLINE_P.
* config/i386/i386.c (TARGET_CAN_INLINE_P): Likewise.
* config/mep/mep.c (TARGET_CAN_INLINE_P): Likewise.
(mep_target_can_inline_p): Rename from
mep_target_option_can_inline_p.
I think I would have changed the docs rather than the code, but in any
case it is fixed.
Ian
prev parent reply other threads:[~2009-10-23 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 11:52 Mohamed Shafi
2009-10-23 14:57 ` Ian Lance Taylor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mcrpr8exjmi.fsf@dhcp-172-17-9-151.mtv.corp.google.com \
--to=iant@google.com \
--cc=gcc@gcc.gnu.org \
--cc=shafitvm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).