From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27658 invoked by alias); 1 Sep 2010 19:46:21 -0000 Received: (qmail 27643 invoked by uid 22791); 1 Sep 2010 19:46:20 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Sep 2010 19:46:16 +0000 Received: from hpaq12.eem.corp.google.com (hpaq12.eem.corp.google.com [172.25.149.12]) by smtp-out.google.com with ESMTP id o81JkDaj013293 for ; Wed, 1 Sep 2010 12:46:13 -0700 Received: from pzk33 (pzk33.prod.google.com [10.243.19.161]) by hpaq12.eem.corp.google.com with ESMTP id o81JkBT3008656 for ; Wed, 1 Sep 2010 12:46:12 -0700 Received: by pzk33 with SMTP id 33so3586659pzk.28 for ; Wed, 01 Sep 2010 12:46:11 -0700 (PDT) Received: by 10.114.52.2 with SMTP id z2mr9437500waz.84.1283370365849; Wed, 01 Sep 2010 12:46:05 -0700 (PDT) Received: from coign.google.com (dhcp-172-22-124-172.mtv.corp.google.com [172.22.124.172]) by mx.google.com with ESMTPS id r37sm12478581wak.11.2010.09.01.12.46.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 01 Sep 2010 12:46:04 -0700 (PDT) From: Ian Lance Taylor To: Jeremiah Willcock Cc: gcc@gcc.gnu.org Subject: Re: Error message formatting feature request References: Date: Wed, 01 Sep 2010 19:46:00 -0000 In-Reply-To: (Jeremiah Willcock's message of "Wed, 1 Sep 2010 15:41:58 -0400 (EDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2010-09/txt/msg00011.txt.bz2 Jeremiah Willcock writes: > When compiling a program such as: > > template > void foo(T, typename T::type c) {c.y();} > struct x {typedef int type;}; > void f() {foo(x(), 3);} > > GCC 4.5.0 (correctly) produces the error message: > > foo.cpp: In function =E2=80=98void foo(T, typename T::type) [with T =3D x, > typename T::type =3D int]=E2=80=99: > foo.cpp:4:21: instantiated from here > foo.cpp:2:34: error: request for member =E2=80=98y=E2=80=99 in =E2=80=98c= =E2=80=99, which is of > non-class type =E2=80=98x::type=E2=80=99 > > My feature request is to have the comma between "T =3D x" and "typename > T::type =3D int" replaced by a semicolon. In larger programs, the types > given in the error message often themselves contain commas, while they > do not typically contain semicolons. Thus, this change would make the > error messages easier to understand (and, in particular, to skim). Thanks for the suggestion. Please open a feature request at http://gcc.gnu.org/bugzilla/ for this. Otherwise I'm afraid this suggestion will just be lost in the noise. Ian