STL warnings recently appeared in the 3.0 branch

STL warnings recently appeared in the 3.0 branch

[Sylvain Pion]

Since very recently (about one week), I get a _lot_ of warnings like the
following with -W -Wall -pedantic :

.../include/g++-v3/bits/stl_alloc.h:494:
warning: aggregate has a partly bracketed initializer
.../include/g++-v3/bits/stl_alloc.h:494:
warning: aggregate has a partly bracketed initializer
.../include/g++-v3/bits/stl_alloc.h:494:
warning: missing initializer for member
   `_pthread_mutex::<anonymous struct>::__pthread_mutex_type'
.../include/g++-v3/bits/stl_alloc.h:494:
warning: missing initializer for member
   `_pthread_mutex::__pthread_mutex_lock'
.../include/g++-v3/bits/stl_alloc.h:494:
warning: missing initializer for member
   `_pthread_mutex::__pthread_mutex_data'

I don't get them on GNU-Linux, but they appear on Solaris.

-- 
Sylvain

Re: STL warnings recently appeared in the 3.0 branch

[Alexandre Oliva]

On Jun 14, 2001, Sylvain Pion <Sylvain.Pion@sophia.inria.fr> wrote:

> .../include/g++-v3/bits/stl_alloc.h:494:
> warning: aggregate has a partly bracketed initializer

> I don't get them on GNU-Linux, but they appear on Solaris.

IIRC, this is a bug in Solaris' headers.  The initializer for mutexes
defined in some header file triggers this warning.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me

Re: STL warnings recently appeared in the 3.0 branch

[Loren James Rittle]

[Note to Dave: all threaded configurations of STL for Solaris use
 __GTHREAD_MUTEX_INIT.]

> Since very recently (about one week), I get a _lot_ of warnings like the
> following with -W -Wall -pedantic :
> .../include/g++-v3/bits/stl_alloc.h:494: [...]
> I don't get them on GNU-Linux, but they appear on Solaris.

Thank you for this bug report.  However, it was filed in the wrong
place and without enough details.  Please file a GNATS report, if at
all possible (see http://gcc.gnu.org ) since then we won't lose your
report.

In your report please include *all* output from ``g++ -v''.  And a
small test case, if possible (the preprocessed version should also be
uploaded when the GNATS report is filed).

For example:

; /usr/local/beta-gcc/bin/g++ -v
Reading specs from /usr/local/beta-gcc/lib/gcc-lib/sparc-sun-solaris2.7/3.0/specs
Configured with: /usr/users/rittle/outside-cvs-src/gcc-3.0/configure --prefix=/usr/local/beta-gcc --disable-libgcj --enable-threads --with-gnu-as --with-as=/usr/local/beta-gcc/bin/as --with-gnu-ld --with-ld=/usr/local/beta-gcc/bin/ld : (reconfigured)  : (reconfigured)  : (reconfigured) 
Thread model: posix
gcc version 3.0 20010612 (prerelease)

; cat t.C
// This example is known to include stl_alloc.h.
#include <vector>

int main () {}

; /usr/local/beta-gcc/bin/g++ -W -Wall -pedantic t.C
;

I.e., this is not a real bug report since I see none of the errors you
have mentioned on my solaris2.7 configuration...
-- 
Loren J. Rittle
Senior Staff Software Engineer, Distributed Object Technology Lab
Networks and Infrastructure Research Lab (IL02/2240), Motorola Labs
rittle@rsch.comm.mot.com, KeyID: 2048/ADCE34A5, FDC0292446937F2A240BC07D42763672

Re: STL warnings recently appeared in the 3.0 branch

[Sylvain Pion]

On Thu, Jun 14, 2001 at 08:42:04PM -0500, Loren James Rittle wrote:
> > Since very recently (about one week), I get a _lot_ of warnings like the
> > following with -W -Wall -pedantic :
> > .../include/g++-v3/bits/stl_alloc.h:494: [...]
> > I don't get them on GNU-Linux, but they appear on Solaris.
> 
> Thank you for this bug report.  However, it was filed in the wrong
> place and without enough details.  Please file a GNATS report, if at
> all possible (see http://gcc.gnu.org ) since then we won't lose your
> report.

Sorry about that.
I've just filed it in GNATS as PR 3195.

-- 
Sylvain

Re: STL warnings recently appeared in the 3.0 branch

[John David Anglin]

> On Jun 14, 2001, Sylvain Pion <Sylvain.Pion@sophia.inria.fr> wrote:

> > .../include/g++-v3/bits/stl_alloc.h:494:
> > warning: aggregate has a partly bracketed initializer

> > I don't get them on GNU-Linux, but they appear on Solaris.

> IIRC, this is a bug in Solaris' headers.  The initializer for mutexes
> defined in some header file triggers this warning.

If you are using solaris threads (gthr-solaris.h), the system headers
(thread.h) are supposed to define DEFAULTMUTEX.  If they don't, the
initializer is broken and the STL mutex locking won't work properly.
The integration of GTHREADS into v3 is new which is why your seeing
the warning.  My previous comments probably don't apply to solaris.

The file gthr-solaris.h may need to check to see if DEFAULTMUTEX is
defined.  If it isn't then, some fallback is needed.  This could be
defining DEFAULTMUTEX, or using __GTHREAD_ONCE_INIT_FUNCTION instead
of __GTHREAD_ONCE_INIT.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6605)

Re: STL warnings recently appeared in the 3.0 branch

[John David Anglin]

> .../include/g++-v3/bits/stl_alloc.h:494:
> warning: aggregate has a partly bracketed initializer

The warning should be harmless.  However to squelch, a define is
needed for __GTHREAD_MUTEX_INIT_DEFAULT if you are using a thread
package that defines __GTHREAD_MUTEX_INIT_FUNCTION.  I have installed
an appropriate one in gthr-dce.h.  However, defines are needed for
gthr-rtems.h and gthr-win32.h.  If you know how the mutex type
is defined for these, it would be greatly be appreciated if a
patch could be developed and tested.

Let me know if you are not using either of these thread models because
this would point to a problem in defining __STL_MUTEX_INITIALIZER in
stl_threads.h.

You have to be careful building v3 because copies of gthr.h and the
gthr* file go into the v3 build tree.  Upates to these files in the
gcc directory may not cause the files in the v3 build tree to update.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6605)