From: Alexandre Oliva <aoliva@redhat.com>
To: "Arthur Haas" <ahaas@impactweather.com>
Cc: <gcc@gcc.gnu.org>, gcc-patches@gcc.gnu.org
Subject: Re: Bootstrap failures on solaris
Date: Wed, 10 Jun 2009 07:20:00 -0000 [thread overview]
Message-ID: <orzlcgsggi.fsf@free.oliva.athome.lsd.ic.unicamp.br> (raw)
In-Reply-To: <D6377241163C404BB17FD866EB63D00203B4AD45@chicago.impactweather.local> (Arthur Haas's message of "Tue\, 9 Jun 2009 13\:03\:35 -0500")
[-- Attachment #1: Type: text/plain, Size: 484 bytes --]
On Jun 9, 2009, "Arthur Haas" <ahaas@impactweather.com> wrote:
> Now that this patch has been commited, the build on i386-pc-solaris2.10
> /export/home/arth/gnu/gcc.git/gcc/gcc.c: In function 'compare_files':
> /export/home/arth/gnu/gcc.git/gcc/gcc.c:6635:2: error: request for
> implicit conversion from 'void *' to 'caddr_t' not permitted in C++
Every other call to munmap in gcc/ is given a char* or has a cast to
caddr_t.
This patch should fix it. I'll check it in shortly.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gcc-compare-debug-munmap-caddr.patch --]
[-- Type: text/x-patch, Size: 528 bytes --]
for gcc/ChangeLog
from Alexandre Oliva <aoliva@redhat.com>
* gcc.c (compare_files): Cast munmap argumento to caddr_t.
Index: gcc/gcc.c
===================================================================
--- gcc/gcc.c.orig 2009-06-08 04:45:28.000000000 -0300
+++ gcc/gcc.c 2009-06-10 04:17:33.000000000 -0300
@@ -6632,7 +6632,7 @@ compare_files (char *cmpfile[])
for (i = 0; i < 2; i++)
if (map[i])
- munmap (map[i], length[i]);
+ munmap ((caddr_t) map[i], length[i]);
if (ret >= 0)
return ret;
[-- Attachment #3: Type: text/plain, Size: 258 bytes --]
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer
next prev parent reply other threads:[~2009-06-10 7:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 14:36 Art Haas
2009-06-09 15:33 ` Revital1 Eres
2009-06-09 15:45 ` Adam Nemet
2009-06-09 18:03 ` Arthur Haas
2009-06-09 21:28 ` Ian Lance Taylor
2009-06-09 22:52 ` Jonathan Wakely
2009-06-10 7:20 ` Alexandre Oliva [this message]
2009-06-09 15:41 ` Kaveh R. GHAZI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orzlcgsggi.fsf@free.oliva.athome.lsd.ic.unicamp.br \
--to=aoliva@redhat.com \
--cc=ahaas@impactweather.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).