From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19094 invoked by alias); 14 Apr 2010 12:01:10 -0000 Received: (qmail 19074 invoked by uid 22791); 14 Apr 2010 12:01:09 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45 X-Spam-Check-By: sourceware.org Received: from mail-yx0-f196.google.com (HELO mail-yx0-f196.google.com) (209.85.210.196) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Apr 2010 12:01:05 +0000 Received: by yxe34 with SMTP id 34so25673yxe.8 for ; Wed, 14 Apr 2010 05:01:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.79.14 with HTTP; Wed, 14 Apr 2010 05:01:03 -0700 (PDT) In-Reply-To: <20100414114434.GA9108@virgil.suse.cz> References: <20100414114434.GA9108@virgil.suse.cz> Date: Wed, 14 Apr 2010 12:12:00 -0000 Received: by 10.151.18.10 with SMTP id v10mr6578687ybi.51.1271246463742; Wed, 14 Apr 2010 05:01:03 -0700 (PDT) Message-ID: Subject: Re: Copy assignments for non scalar types From: Richard Guenther To: Richard Guenther , Diego Novillo , Sebastian Pop , gcc@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2010-04/txt/msg00326.txt.bz2 On Wed, Apr 14, 2010 at 1:44 PM, Martin Jambor wrote: > Hi, > > On Wed, Apr 14, 2010 at 01:31:05PM +0200, Richard Guenther wrote: >> On Wed, 14 Apr 2010, Diego Novillo wrote: >> >> > On Wed, Apr 14, 2010 at 04:40, Richard Guenther wr= ote: >> > >> > > No. =A0make_rename_temp should go away. =A0Please. >> > >> > I don't disagree, in principle (less code is always good). =A0What is >> > wrong with it? >> >> It asks the SSA renamer to put your new variables into SSA form. >> It's very simple to do that manually (at least if no PHIs are >> involved), so better do that. >> > > The problem of using create_tmp_var directly is that the following > pattern is now bound to creep up at quite many places: > > =A0 =A0 =A0tmp =3D create_tmp_var (TREE_TYPE (adj->base), "blah"); > =A0 =A0 =A0if (TREE_CODE (TREE_TYPE (tmp)) =3D=3D COMPLEX_TYPE > =A0 =A0 =A0 =A0 =A0|| TREE_CODE (TREE_TYPE (tmp)) =3D=3D VECTOR_TYPE) > =A0 =A0 =A0 =A0DECL_GIMPLE_REG_P (tmp) =3D 1; > > Perhaps we should have something like create_gimple_reg_tmp_var that > would do this? =A0If so, I'll be happy to add it. Yes. I suggest create_tmp_reg as a name for that (simply add a wrapper around create_tmp_var). Richard. > Martin >