From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id D04513858D20 for ; Sun, 25 Jun 2023 20:11:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D04513858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E14652185A; Sun, 25 Jun 2023 20:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1687723865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DOj0knh9yH2yelTRy2T4TVTAu8hocIZshJDTepWUTu4=; b=Falxfe7CFMDcOFtXbiJ4QpB4s5T/vCcJDSL/Av2Sz+LNXqf4zqkBmuG4iZ5O5SoMTrlAIQ coHke76pHNLs0pQAdZnBKu8TN1zHTp8MLvnaP3e2vCu1ogIMu6Z0EZM/6+XdQW6/k7V+UP 8LZEpBifHtuvxJgsGLIrpXYUDXec5zE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1687723865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DOj0knh9yH2yelTRy2T4TVTAu8hocIZshJDTepWUTu4=; b=ouH/nVZXQkbrezDOPP3CPhAAgL7ZnHozjGO6cq8bcHA/8k8RZ8bGIMFhqrim5pYTaHXzli +nGTOQRg1IHhZIBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D394C13462; Sun, 25 Jun 2023 20:11:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GtW9MlmfmGQ7LAAAMHmgww (envelope-from ); Sun, 25 Jun 2023 20:11:05 +0000 From: Martin Jambor To: Roger Sayle Cc: 'GCC Mailing List' Subject: RE: Issue generating GCC coverage report since r14-1625-geba3565ce6d766 In-Reply-To: <015c01d9a05f$68a06660$39e13320$@nextmovesoftware.com> References: <015c01d9a05f$68a06660$39e13320$@nextmovesoftware.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/28.2 (x86_64-suse-linux-gnu) Date: Sun, 25 Jun 2023 22:11:05 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,KAM_SHORT,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Roger, sorry for late reply, rather unexpectedly I found myself traveling last week. On Fri, Jun 16 2023, Roger Sayle wrote: > Hi Martin, > It's great to hear from you. My apologies for the inconvenience. > I believe that the problem has been solved by Jakub's patch: > https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommit;f=3Dgcc/config/i386/i386.= md;h=3D43a3252c42af12ad90082e4088ea58eecd0bf582 Unfortunately the situation remains the same, even with the above patch in master. The workaround I hoped for (adding --ignore-errors mismatch) does not help either, the whole process then fails later on. Perhaps adding another --ignore-errors elsewhere may fix this, but at the moment I need to defer playing with this for a few weeks. Thanks, Martin > > I strongly suspect that the problem was that my patch was emitting "(cons= t_int 0)" as > an instruction into the RTL stream, which I'd misunderstood to be recogni= zed as a > no-op by the middle-end. This isn't the case and the correct idiom is to= (also) use: > emit_note (NOTE_INSN_DELETED); DONE; > > I can easily believe that this unintended behaviour is/was interfering wi= th your code > coverage scripts (I should study your posted results). > > I hope this explains things. Please let me know if things really are not= fixed (or not). > Cheers, > Roger > -- > >> -----Original Message----- >> From: Martin Jambor >> Sent: 16 June 2023 13:51 >> To: GCC Mailing List >> Cc: Roger Sayle >> Subject: Issue generating GCC coverage report since r14-1625-geba3565ce6= d766 >>=20 >> Hello, >>=20 >> we try to build coverage info for GCC for our testsuite and upload it to >> https://gcc.opensuse.org/gcc-lcov/ every weekend. But since patch >> r14-1625-geba3565ce6d766 (Add support for stc and cmc instructions in >> i386.md) the generation broke down. However, I don't think there is som= ething >> necessarily wrong with that particular commit, at least I don't see anyt= hing >> suspicious. >>=20 >> I inherited the generating script from Martin Li=C5=A1ka and have not re= ally looked >> much into it much, but it simply does the following after a fresh GCC ma= ster >> checkout (I added the --disable-multilib and reduced the number of langu= ages to >> reproduce this more quickly): >>=20 >>=20 >> ../src/configure --prefix=3D/home/mjambor/gcc/mine/inst --enable- >> languages=3Dc,c++ --disable-bootstrap --enable-host-shared --enable-cove= rage=3Dopt >> --disable-multilib >> make -j64 && make -j64 -k check >> find gcc/testsuite/ -name '*.gcda' -exec rm -rvf {} \; # I don't know= why the >> script does this >> lcov -d . --capture --output-file gcc.info >>=20 >>=20 >> and this last step, since the commit, when processing file ./gcc/insn-at= trtab.gcda >> fails with error: >>=20 >> geninfo: ERROR: mismatched end line for _Z12get_attr_isaP8rtx_insn at >> /home/mjambor/gcc/mine/src/gcc/config/i386/i386.md:5776: 5776 -> 8963 >> (use "geninfo --ignore-errors mismatch ..." to bypass this err= or) >>=20 >> I tried looking briefly into the perl sources of lcov and geninfo but I = am afraid I >> don't have the necessary knowledge of the language and the tool or the t= ime to >> properly debug this. So I am inclined to simply add --ignore-errors mis= match to >> lcov options, which avoids the issue, and be done with it. Nevertheless= , I thought >> I'd mention this here in case anyone here has any ideas what can be goin= g wrong. >>=20 >> Thanks, >>=20 >> Martin