From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 180543858C62 for ; Tue, 28 Mar 2023 21:31:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 180543858C62 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 36AC021A11; Tue, 28 Mar 2023 21:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1680039097; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q0PKty04YQYqgbIdcl2nKEhsnVO3TFA5e9IoX7L3hC8=; b=LcN5N511Q9SS+z2kYuIEygtzXIjxKsfojobEcrrKUwoBgWGwR+vRKwxpATrn3dfZ66rQqU /cVMztMtOoezCVkqtlApkBiIsYmo87y9vN7oSuD0I6UzmFW6ZSJ5/EPyfWVY7PIvKaGr7H iJKL16QHX1ACJAXFrmmRCpcA5pLZJVo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1680039097; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q0PKty04YQYqgbIdcl2nKEhsnVO3TFA5e9IoX7L3hC8=; b=yx+N96O7QflFVqygwnlpUcTYLYBtRJFWit7A71c8SHMDYDauAM8AuzE/xoTfsPvLKA3bty Cwh6Hx+tn3N+5qDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 230921390D; Tue, 28 Mar 2023 21:31:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VF+HB7lcI2TJQgAAMHmgww (envelope-from ); Tue, 28 Mar 2023 21:31:37 +0000 From: Martin Jambor To: Benjamin Priour Cc: David Malcolm , gcc@gcc.gnu.org, Jason Merrill Subject: Re: [GSoC] Discussion of warnings and of a first patch (name-hiding) In-Reply-To: References: User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/28.2 (x86_64-suse-linux-gnu) Date: Tue, 28 Mar 2023 23:31:30 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, it feels like I have read only a small part of your conversation and so may be missing quite some context, but... On Wed, Mar 22 2023, Benjamin Priour via Gcc wrote: > Hi Jason, > > Sorry for the delayed answer, I was in my exam period! > > I've almost finished the patch (PR12341 > ), and wrote a testcase > to compare it against. > In it I use dejaGNU instructions of the format: > /* { dg-warning "'C::bbb' might shadow 'B::bbb'." "" { target *-*-* } > C_shadowing_bbb } */ > and run the test with: > make check-gcc-c++ RUNTESTFLAGS="-v -v --target_board=unix\{-m32,-m64\} > dg.exp=pr12341-1.C" > I get expected results on most target, except on target hppa*-*-hpux*. ...don't worry about hppa or hpux at this point and... > I have been looking around the documentation, yet I cannot find a way to > run on that target specifically, especially considering the wildcards. How > to test GCC on a simulator don't > specify that target in the bottom table. > Would you have any guidance on how to do so ? I would like to debug the > test on that platform. > > Otherwise, I believe it is working just fine, I put it as an enhancement to > -Wshadow. Should I send it to gcc-patches ? I wasn't sure I was supposed to > since it's still buggy, so I preferred to refrain. ...yes, if you would like to get feedback, send it to gcc-patches. Prefix the subject with "[RFC]" if you want to point out that you are looking for feedback and not an approval to commit. Spell out any known issues. It is a good idea to CC some maintainer of the gcc component you modify, so Jason in this case. Thanks for your perseverance, I know it is not easy, Martin