From: Jason Merrill <jason@cygnus.com>
To: egcs@cygnus.com, tot@trema.com, law@cygnus.com
Cc: wilson@cygnus.com
Subject: Re: [REPOST] MT-safe exception diffs for 971207
Date: Thu, 11 Dec 1997 19:51:00 -0000 [thread overview]
Message-ID: <u9d8j32pxf.fsf@yorick.cygnus.com> (raw)
In-Reply-To: <199712111608.RAA16152.cygnus.egcs@lev.labs.trema.com>
Looks great, thanks a lot! Some minor comments:
In use_eh_context, why are you using copy_rtx on a REG rtx? That's a nop.
I'm not sure why you need five functions to handle eh_context.
Indeed, the saved_pc stuff can be commented out ifdef DWARF2_UNWIND_INFO.
In fact, I'm about to blow away the old unwind code that uses saved_pc, so
you don't need to worry about making it work. I'll be removing it just
after your patch goes in.
Why do you cast &eh->info and &eh->dynamic_handler_chain to their own
types?
Since you only use ptr_ptr_type_node once, there's no need to save it in a
global variable.
I'd just as soon put this patch in now and get a second patch for these
tweaks; Jeff?
Jason
next parent reply other threads:[~1997-12-11 19:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <199712111608.RAA16152.cygnus.egcs@lev.labs.trema.com>
1997-12-11 19:51 ` Jason Merrill [this message]
1997-12-11 19:51 ` Jeffrey A Law
1997-12-12 3:55 ` Teemu Torma
[not found] ` <u9d8j32pxf.fsf.cygnus.egcs@yorick.cygnus.com>
1997-12-12 0:18 ` Jason Merrill
1997-12-12 1:52 ` Teemu Torma
1997-12-12 1:52 ` Jason Merrill
1997-12-12 1:18 ` Teemu Torma
1997-12-12 1:18 ` Jason Merrill
1997-12-12 8:32 ` David Edelsohn
1997-12-11 8:08 Teemu Torma
1997-12-17 5:04 ` Andrey Slepuhin
1997-12-17 5:14 ` Teemu Torma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u9d8j32pxf.fsf@yorick.cygnus.com \
--to=jason@cygnus.com \
--cc=egcs@cygnus.com \
--cc=law@cygnus.com \
--cc=tot@trema.com \
--cc=wilson@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).