* regmove broken
@ 1998-02-02 2:07 Andreas Schwab
1998-02-02 10:23 ` Jeffrey A Law
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 1998-02-02 2:07 UTC (permalink / raw)
To: egcs
This change to regmove.c is broken:
(fixup_match_1): Remove statement with no effect: "if (0) ;".
This if is really needed, which becomes obvious when looking at the lines
that follow.
1998-01-30 Andreas Schwab <schwab@issan.informatik.uni-dortmund.de>
* regmove.c (fixup_match_1): Undo last change, and add a comment
explaining this.
*** egcs-980129/gcc/regmove.c.~1~ Fri Jan 30 19:10:00 1998
--- egcs-980129/gcc/regmove.c Fri Jan 30 19:49:44 1998
*************** fixup_match_1 (insn, set, src, src_subre
*** 1216,1222 ****
}
}
}
!
#if defined (HAVE_PRE_INCREMENT) || defined (HAVE_PRE_DECREMENT)
else if ((code == PLUS || code == MINUS) && insn_const
&& try_auto_increment (p, insn, 0, src, insn_const, 1))
--- 1216,1226 ----
}
}
}
!
! /* Don't remove this seemingly useless if, it is needed to pair with the
! else in the next two conditionally included code blocks. */
! if (0)
! {;}
#if defined (HAVE_PRE_INCREMENT) || defined (HAVE_PRE_DECREMENT)
else if ((code == PLUS || code == MINUS) && insn_const
&& try_auto_increment (p, insn, 0, src, insn_const, 1))
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: regmove broken
1998-02-02 2:07 regmove broken Andreas Schwab
@ 1998-02-02 10:23 ` Jeffrey A Law
0 siblings, 0 replies; 3+ messages in thread
From: Jeffrey A Law @ 1998-02-02 10:23 UTC (permalink / raw)
To: Andreas Schwab; +Cc: egcs
In message < vyz1zxmwcaz.fsf@issan.informatik.uni-dortmund.de >you write:
> This change to regmove.c is broken:
>
> (fixup_match_1): Remove statement with no effect: "if (0) ;".
>
> This if is really needed, which becomes obvious when looking at the lines
> that follow.
>
>
> 1998-01-30 Andreas Schwab <schwab@issan.informatik.uni-dortmund.de>
>
> * regmove.c (fixup_match_1): Undo last change, and add a comment
> explaining this.
THanks. Installed.
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: regmove broken
@ 1998-02-02 11:43 Kaveh R. Ghazi
0 siblings, 0 replies; 3+ messages in thread
From: Kaveh R. Ghazi @ 1998-02-02 11:43 UTC (permalink / raw)
To: egcs, schwab
> From: Andreas Schwab <schwab@issan.informatik.uni-dortmund.de>
>
> This change to regmove.c is broken:
>
> (fixup_match_1): Remove statement with no effect: "if (0) ;".
>
> This if is really needed, which becomes obvious when looking at the lines
> that follow.
>
>
> 1998-01-30 Andreas Schwab <schwab@issan.informatik.uni-dortmund.de>
>
> * regmove.c (fixup_match_1): Undo last change, and add a comment
> explaining this.
>
My mistake, sorry. Thanks for catching this.
--Kaveh
--
Kaveh R. Ghazi Project Manager / Custom Development
ghazi@caip.rutgers.edu ICon CMT Corp.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~1998-02-02 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-02-02 2:07 regmove broken Andreas Schwab
1998-02-02 10:23 ` Jeffrey A Law
1998-02-02 11:43 Kaveh R. Ghazi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).