From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Schwab <schwab@issan.informatik.uni-dortmund.de>
To: "Marc Rouaix" <rouaix@my-dejanews.com>
Cc: egcs@cygnus.com
Subject: Re: suggest parentheses around assignment used as truth value
Date: Wed, 01 Jul 1998 02:51:00 -0000
Message-id: <vyzra05vqzo.fsf@issan.informatik.uni-dortmund.de>
References: <JMDHPDCIACOECAAA@my-dejanews.com>
X-SW-Source: 1998-07/msg00024.html

"Marc Rouaix" <rouaix@my-dejanews.com> writes:

|> I'd just like to register my opiniont that code like
|> 
|> if (x = p()) {...}
|> 
|> shouldn't generate a warning under gcc -Wall.

What if you have a typo here?

|>  Even if
|> you feel that code like this is obscure, the recommended
|> 
|> if ((x = p())) {...}
|> 
|> is just bizarre.

Then write it as:

	x = p();
	if (x) {...}

-- 
Andreas Schwab                                      "And now for something
schwab@issan.informatik.uni-dortmund.de              completely different"
schwab@gnu.org