public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Use "false" in compile_cplus_convert_enum
@ 2019-05-04 20:14 Tom Tromey
  0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2019-05-04 20:14 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9c056022194f9d1f068885cb45c9d23a2e44db54

commit 9c056022194f9d1f068885cb45c9d23a2e44db54
Author: Tom Tromey <tom@tromey.com>
Date:   Wed Apr 24 16:19:51 2019 -0600

    Use "false" in compile_cplus_convert_enum
    
    This changes compile_cplus_convert_enum to use "false".
    
    Note that this variable is never modified, which seems like an error.
    I filed PR compile/24473 for this.
    
    gdb/ChangeLog
    2019-05-04  Tom Tromey  <tom@tromey.com>
    
    	* compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
    	"false".

Diff:
---
 gdb/ChangeLog                     | 5 +++++
 gdb/compile/compile-cplus-types.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d0a6f3a..4763a83 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2019-05-04  Tom Tromey  <tom@tromey.com>
 
+	* compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
+	"false".
+
+2019-05-04  Tom Tromey  <tom@tromey.com>
+
 	* arc-tdep.c (arc_tdesc_init): Use bool.
 
 2019-05-04  Tom Tromey  <tom@tromey.com>
diff --git a/gdb/compile/compile-cplus-types.c b/gdb/compile/compile-cplus-types.c
index ee3bb43..6923930 100644
--- a/gdb/compile/compile-cplus-types.c
+++ b/gdb/compile/compile-cplus-types.c
@@ -910,7 +910,7 @@ static gcc_type
 compile_cplus_convert_enum (compile_cplus_instance *instance, struct type *type,
 			    enum gcc_cp_symbol_kind nested_access)
 {
-  int scoped_enum_p = FALSE;
+  bool scoped_enum_p = false;
 
   /* Create a new scope for this type.  */
   compile_scope scope = instance->new_scope (TYPE_NAME (type), type);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-05-04 20:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-04 20:14 [binutils-gdb] Use "false" in compile_cplus_convert_enum Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).