public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix remove-inferiors.exp FAIL with readnow board
Date: Tue, 11 Jun 2019 11:54:00 -0000	[thread overview]
Message-ID: <20190611115421.115033.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fea82da0fe15137fda0056c0f0b92b6e70997ea8

commit fea82da0fe15137fda0056c0f0b92b6e70997ea8
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Jun 11 13:54:10 2019 +0200

    [gdb/testsuite] Fix remove-inferiors.exp FAIL with readnow board
    
    We see this failure with the readnow board:
    ...
    FAIL: gdb.multi/remove-inferiors.exp: load binary
    ...
    
    When running with board readnow, an extra message "Expanding full symbols" is
    emitted after the "Reading symbols" message, and the regexp corresponding to
    the FAIL only allows the first message.
    
    Fix this by allowing the extra message in the regexp.
    
    gdb/testsuite/ChangeLog:
    
    2019-06-11  Tom de Vries  <tdevries@suse.de>
    
    	PR testsuite/24521
    	* gdb.multi/remove-inferiors.exp: Allow "Expanding full symbols"
    	message.

Diff:
---
 gdb/testsuite/ChangeLog                      | 6 ++++++
 gdb/testsuite/gdb.multi/remove-inferiors.exp | 5 +++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 0eaf7bbed..c42b963 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,6 +1,12 @@
 2019-06-11  Tom de Vries  <tdevries@suse.de>
 
 	PR testsuite/24521
+	* gdb.multi/remove-inferiors.exp: Allow "Expanding full symbols"
+	message.
+
+2019-06-11  Tom de Vries  <tdevries@suse.de>
+
+	PR testsuite/24521
 	* gdb.dwarf2/nonvar-access.exp: Fix main high_pc.
 
 2019-06-11  Tom de Vries  <tdevries@suse.de>
diff --git a/gdb/testsuite/gdb.multi/remove-inferiors.exp b/gdb/testsuite/gdb.multi/remove-inferiors.exp
index ec13ce5..18f6c90 100644
--- a/gdb/testsuite/gdb.multi/remove-inferiors.exp
+++ b/gdb/testsuite/gdb.multi/remove-inferiors.exp
@@ -49,8 +49,9 @@ proc test_remove_inferiors { } {
     # Load binfile and start the inferior.
     set binfile_re [string_to_regexp ${binfile}]
     gdb_test "file ${binfile}" \
-	     "Reading symbols from ${binfile_re}..." \
-	     "load binary"
+	[multi_line "Reading symbols from ${binfile_re}\.\.\.(" \
+	     "Expanding full symbols from ${binfile_re}\.\.\.)?" ] \
+	"load binary"
 
     if {![runto_main]} {
 	fail "couldn't run to main."


                 reply	other threads:[~2019-06-11 11:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190611115421.115033.qmail@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).