public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Mark ptype_union.exp as unsupported for cc-with-gdb-index
@ 2019-06-21 15:03 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2019-06-21 15:03 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b13a7d03c29e28bc0b38ce166ad1907403709d36

commit b13a7d03c29e28bc0b38ce166ad1907403709d36
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Jun 21 17:03:27 2019 +0200

    [gdb/testsuite] Mark ptype_union.exp as unsupported for cc-with-gdb-index
    
    When testing gdb with board cc-with-gdb-index, we run into:
    ...
    FAIL: gdb.ada/ptype_union.exp: ptype global
    FAIL: gdb.ada/ptype_union.exp: print global
    ...
    
    The index is not supported for Ada (PR24713), and cc-with-gdb-index does not
    add an index for Ada test-cases.  However, this test-case compiles C sources,
    for which cc-with-gdb-index does add an index.  In gdb we load the executable
    containing the index and set the language to Ada, resulting in gdb trying to
    handle something that is not supported.
    
    Fix the fail by marking this unsupported.
    
    Tested on x86_64-linux.
    
    gdb/testsuite/ChangeLog:
    
    2019-06-21  Tom de Vries  <tdevries@suse.de>
    
    	PR testsuite/24518
    	PR ada/24713
    	* gdb.ada/ptype_union.exp: Mark as unsupported if executable contains
    	index.

Diff:
---
 gdb/testsuite/ChangeLog               | 7 +++++++
 gdb/testsuite/gdb.ada/ptype_union.exp | 5 +++++
 2 files changed, 12 insertions(+)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 60a19eb..d4e7d8b 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,10 @@
+2019-06-21  Tom de Vries  <tdevries@suse.de>
+
+	PR testsuite/24518
+	PR ada/24713
+	* gdb.ada/ptype_union.exp: Mark as unsupported if executable contains
+	index.
+
 2019-06-19  Tom Tromey  <tromey@adacore.com>
 
 	* gdb.ada/length_cond.exp: Add intro comment.
diff --git a/gdb/testsuite/gdb.ada/ptype_union.exp b/gdb/testsuite/gdb.ada/ptype_union.exp
index 4f33721..c27db1f 100644
--- a/gdb/testsuite/gdb.ada/ptype_union.exp
+++ b/gdb/testsuite/gdb.ada/ptype_union.exp
@@ -19,6 +19,11 @@ if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile}]} {
     return -1
 }
 
+if {[exec_has_index_section $binfile]} {
+    unsupported "Ada is not currently supported by the index (PR 24713)"
+    return -1
+}
+
 # The test case is written in C, because it was easy to make the
 # required type there; but the bug itself only happens in Ada.
 gdb_test "set lang ada" ""


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-06-21 15:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-21 15:03 [binutils-gdb] [gdb/testsuite] Mark ptype_union.exp as unsupported for cc-with-gdb-index Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).