public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Remove redundant check from make_visible
Date: Tue, 25 Jun 2019 13:59:00 -0000	[thread overview]
Message-ID: <20190625135939.120828.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8e2daf1532e587fee8d14aab1baad40e628065e2

commit 8e2daf1532e587fee8d14aab1baad40e628065e2
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Jun 16 15:17:52 2019 -0600

    Remove redundant check from make_visible
    
    This removes a check of the window type from make_visible.  This
    function already checks that the window type is not CMD_WIN near the
    top, so this condition can never be false.
    
    gdb/ChangeLog
    2019-06-25  Tom Tromey  <tom@tromey.com>
    
    	* tui/tui-wingeneral.c (make_visible): Remove check of window
    	type.

Diff:
---
 gdb/ChangeLog            | 5 +++++
 gdb/tui/tui-wingeneral.c | 4 +---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 174d12b..0d66374 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2019-06-25  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui-wingeneral.c (make_visible): Remove check of window
+	type.
+
+2019-06-25  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui-win.c (tui_win_info::max_height)
 	(tui_cmd_window::max_height): New methods.
 	(new_height_ok): Call max_height.
diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c
index 4d168af..73d77ce 100644
--- a/gdb/tui/tui-wingeneral.c
+++ b/gdb/tui/tui-wingeneral.c
@@ -181,9 +181,7 @@ make_visible (struct tui_gen_win_info *win_info, bool visible)
     {
       if (!win_info->is_visible)
 	{
-	  tui_make_window (win_info,
-			   (win_info->type != CMD_WIN
-			    && !tui_win_is_auxillary (win_info->type)));
+	  tui_make_window (win_info, !tui_win_is_auxillary (win_info->type));
 	  win_info->is_visible = true;
 	}
     }


                 reply	other threads:[~2019-06-25 13:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190625135939.120828.qmail@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).