public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Change tui_set_exec_info_content to return void
Date: Tue, 25 Jun 2019 14:01:00 -0000	[thread overview]
Message-ID: <20190625140120.21472.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=73fbdc65a1f3da143e604d95443dc11ee86af710

commit 73fbdc65a1f3da143e604d95443dc11ee86af710
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Jun 16 17:51:34 2019 -0600

    Change tui_set_exec_info_content to return void
    
    tui_set_exec_info_content can't return an error, so change it to
    return void instead.
    
    gdb/ChangeLog
    2019-06-25  Tom Tromey  <tom@tromey.com>
    
    	* tui/tui-winsource.h (tui_set_exec_info_content): Return void.
    	* tui/tui-winsource.c (tui_set_exec_info_content): Return void.

Diff:
---
 gdb/ChangeLog           | 5 +++++
 gdb/tui/tui-winsource.c | 6 +-----
 gdb/tui/tui-winsource.h | 2 +-
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index feec185..dc3a449 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2019-06-25  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui-winsource.h (tui_set_exec_info_content): Return void.
+	* tui/tui-winsource.c (tui_set_exec_info_content): Return void.
+
+2019-06-25  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 	check.
 
diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index 5e60e9e..2de5c53 100644
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -482,11 +482,9 @@ tui_update_breakpoint_info (struct tui_win_info *win,
 /* Function to initialize the content of the execution info window,
    based upon the input window which is either the source or
    disassembly window.  */
-enum tui_status
+void
 tui_set_exec_info_content (struct tui_win_info *win_info)
 {
-  enum tui_status ret = TUI_SUCCESS;
-
   tui_source_window_base *base = (tui_source_window_base *) win_info;
   if (base->execution_info != NULL)
     {
@@ -530,8 +528,6 @@ tui_set_exec_info_content (struct tui_win_info *win_info)
 	}
       exec_info_ptr->content_size = win_info->content_size;
     }
-
-  return ret;
 }
 
 
diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h
index ccc9ae5..3ed461a 100644
--- a/gdb/tui/tui-winsource.h
+++ b/gdb/tui/tui-winsource.h
@@ -53,7 +53,7 @@ extern void tui_update_source_windows_with_line (struct symtab *,
 extern void tui_clear_source_content (struct tui_win_info *, int);
 extern void tui_erase_source_content (struct tui_win_info *, int);
 extern void tui_show_source_content (struct tui_win_info *);
-extern enum tui_status tui_set_exec_info_content (struct tui_win_info *);
+extern void tui_set_exec_info_content (struct tui_win_info *);
 extern void tui_show_exec_info_content (struct tui_win_info *);
 extern void tui_erase_exec_info_content (struct tui_win_info *);
 extern void tui_clear_exec_info_content (struct tui_win_info *);


                 reply	other threads:[~2019-06-25 14:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190625140120.21472.qmail@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).