From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27589 invoked by alias); 25 Jun 2019 14:01:26 -0000 Mailing-List: contact gdb-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: , Sender: gdb-cvs-owner@sourceware.org List-Subscribe: Sender: gdb-cvs-owner@sourceware.org Received: (qmail 27506 invoked by uid 306); 25 Jun 2019 14:01:25 -0000 Date: Tue, 25 Jun 2019 14:01:00 -0000 Message-ID: <20190625140125.27501.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Change more TUI functions to take a tui_source_window_base X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 73fbdc65a1f3da143e604d95443dc11ee86af710 X-Git-Newrev: 21c32dca764039afd3517954f6dd0a23d0c9e16c X-SW-Source: 2019-06/txt/msg00174.txt.bz2 https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=21c32dca764039afd3517954f6dd0a23d0c9e16c commit 21c32dca764039afd3517954f6dd0a23d0c9e16c Author: Tom Tromey Date: Mon Jun 17 12:51:29 2019 -0600 Change more TUI functions to take a tui_source_window_base Several more TUI functions should only be called with a source or disassembly window. This patch changes these functions so that this can be caught at compile time. gdb/ChangeLog 2019-06-25 Tom Tromey * tui/tui-winsource.h (tui_set_exec_info_content) (tui_show_exec_info_content, tui_erase_exec_info_content) (tui_clear_exec_info_content, tui_update_exec_info): Change argument to tui_source_window_base. * tui/tui-winsource.c (tui_set_exec_info_content) (tui_show_exec_info_content, tui_erase_exec_info_content) (tui_clear_exec_info_content, tui_update_exec_info): Change argument to tui_source_window_base. Diff: --- gdb/ChangeLog | 11 +++++++++++ gdb/tui/tui-winsource.c | 26 ++++++++++---------------- gdb/tui/tui-winsource.h | 10 +++++----- 3 files changed, 26 insertions(+), 21 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index dc3a449..43f8a5d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,16 @@ 2019-06-25 Tom Tromey + * tui/tui-winsource.h (tui_set_exec_info_content) + (tui_show_exec_info_content, tui_erase_exec_info_content) + (tui_clear_exec_info_content, tui_update_exec_info): Change + argument to tui_source_window_base. + * tui/tui-winsource.c (tui_set_exec_info_content) + (tui_show_exec_info_content, tui_erase_exec_info_content) + (tui_clear_exec_info_content, tui_update_exec_info): Change + argument to tui_source_window_base. + +2019-06-25 Tom Tromey + * tui/tui-winsource.h (tui_set_exec_info_content): Return void. * tui/tui-winsource.c (tui_set_exec_info_content): Return void. diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c index 2de5c53..e55ce40 100644 --- a/gdb/tui/tui-winsource.c +++ b/gdb/tui/tui-winsource.c @@ -483,12 +483,11 @@ tui_update_breakpoint_info (struct tui_win_info *win, based upon the input window which is either the source or disassembly window. */ void -tui_set_exec_info_content (struct tui_win_info *win_info) +tui_set_exec_info_content (struct tui_source_window_base *win_info) { - tui_source_window_base *base = (tui_source_window_base *) win_info; - if (base->execution_info != NULL) + if (win_info->execution_info != NULL) { - struct tui_gen_win_info *exec_info_ptr = base->execution_info; + struct tui_gen_win_info *exec_info_ptr = win_info->execution_info; if (exec_info_ptr->content == NULL) exec_info_ptr->content = @@ -532,10 +531,9 @@ tui_set_exec_info_content (struct tui_win_info *win_info) void -tui_show_exec_info_content (struct tui_win_info *win_info) +tui_show_exec_info_content (struct tui_source_window_base *win_info) { - tui_source_window_base *base = (tui_source_window_base *) win_info; - struct tui_gen_win_info *exec_info = base->execution_info; + struct tui_gen_win_info *exec_info = win_info->execution_info; int cur_line; werase (exec_info->handle); @@ -552,28 +550,24 @@ tui_show_exec_info_content (struct tui_win_info *win_info) void -tui_erase_exec_info_content (struct tui_win_info *win_info) +tui_erase_exec_info_content (struct tui_source_window_base *win_info) { - tui_source_window_base *base = (tui_source_window_base *) win_info; - struct tui_gen_win_info *exec_info = base->execution_info; + struct tui_gen_win_info *exec_info = win_info->execution_info; werase (exec_info->handle); exec_info->refresh_window (); } void -tui_clear_exec_info_content (struct tui_win_info *win_info) +tui_clear_exec_info_content (struct tui_source_window_base *win_info) { - tui_source_window_base *base = (tui_source_window_base *) win_info; - base->execution_info->content_in_use = FALSE; + win_info->execution_info->content_in_use = FALSE; tui_erase_exec_info_content (win_info); - - return; } /* Function to update the execution info window. */ void -tui_update_exec_info (struct tui_win_info *win_info) +tui_update_exec_info (struct tui_source_window_base *win_info) { tui_set_exec_info_content (win_info); tui_show_exec_info_content (win_info); diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h index 3ed461a..09a9d5a 100644 --- a/gdb/tui/tui-winsource.h +++ b/gdb/tui/tui-winsource.h @@ -53,11 +53,11 @@ extern void tui_update_source_windows_with_line (struct symtab *, extern void tui_clear_source_content (struct tui_win_info *, int); extern void tui_erase_source_content (struct tui_win_info *, int); extern void tui_show_source_content (struct tui_win_info *); -extern void tui_set_exec_info_content (struct tui_win_info *); -extern void tui_show_exec_info_content (struct tui_win_info *); -extern void tui_erase_exec_info_content (struct tui_win_info *); -extern void tui_clear_exec_info_content (struct tui_win_info *); -extern void tui_update_exec_info (struct tui_win_info *); +extern void tui_set_exec_info_content (struct tui_source_window_base *); +extern void tui_show_exec_info_content (struct tui_source_window_base *); +extern void tui_erase_exec_info_content (struct tui_source_window_base *); +extern void tui_clear_exec_info_content (struct tui_source_window_base *); +extern void tui_update_exec_info (struct tui_source_window_base *); extern void tui_alloc_source_buffer (struct tui_win_info *); extern int tui_line_is_displayed (int,