public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Add back missing debug for index-cache.exp
Date: Wed, 26 Jun 2019 03:53:00 -0000	[thread overview]
Message-ID: <20190626035259.101586.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=22e217527d1ba9ff3d933a14c9d81b066fac606d

commit 22e217527d1ba9ff3d933a14c9d81b066fac606d
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Jun 26 05:52:47 2019 +0200

    [gdb/testsuite] Add back missing debug for index-cache.exp
    
    The proc prepare_for_testing has "debug" as default argument for the options
    parameter.
    
    In the commit c596f180a1 "[gdb/testsuite] Compile index-cache.c with
    -Wl,--build-id", by setting the options argument we've effectively dropped
    "debug".  This causes index-cache.exp to not contain any debug info anymore on
    most systems (though not on openSUSE), which causes index-cache.exp FAILs.
    
    Fix this by adding back the missing "debug" option.
    
    Tested on x86_64-linux.
    
    gdb/testsuite/ChangeLog:
    
    2019-06-26  Tom de Vries  <tdevries@suse.de>
    
    	* gdb.base/index-cache.exp: Add back missing debug option.

Diff:
---
 gdb/testsuite/ChangeLog                | 4 ++++
 gdb/testsuite/gdb.base/index-cache.exp | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 8410a09..4f23343 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2019-06-26  Tom de Vries  <tdevries@suse.de>
+
+	* gdb.base/index-cache.exp: Add back missing debug option.
+
 2019-06-23  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 
 	* gdb.base/alias.exp: Test non matching/non existing prefixes.
diff --git a/gdb/testsuite/gdb.base/index-cache.exp b/gdb/testsuite/gdb.base/index-cache.exp
index 6f1488e..f14cbb0 100644
--- a/gdb/testsuite/gdb.base/index-cache.exp
+++ b/gdb/testsuite/gdb.base/index-cache.exp
@@ -19,7 +19,7 @@
 standard_testfile
 
 if { [prepare_for_testing "failed to prepare" $testfile $srcfile \
-	  {additional_flags=-Wl,--build-id}] } {
+	  {debug additional_flags=-Wl,--build-id}] } {
     return
 }


                 reply	other threads:[~2019-06-26  3:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626035259.101586.qmail@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).