public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Add back missing debug for index-cache.exp
@ 2019-06-26  3:53 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2019-06-26  3:53 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=22e217527d1ba9ff3d933a14c9d81b066fac606d

commit 22e217527d1ba9ff3d933a14c9d81b066fac606d
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Jun 26 05:52:47 2019 +0200

    [gdb/testsuite] Add back missing debug for index-cache.exp
    
    The proc prepare_for_testing has "debug" as default argument for the options
    parameter.
    
    In the commit c596f180a1 "[gdb/testsuite] Compile index-cache.c with
    -Wl,--build-id", by setting the options argument we've effectively dropped
    "debug".  This causes index-cache.exp to not contain any debug info anymore on
    most systems (though not on openSUSE), which causes index-cache.exp FAILs.
    
    Fix this by adding back the missing "debug" option.
    
    Tested on x86_64-linux.
    
    gdb/testsuite/ChangeLog:
    
    2019-06-26  Tom de Vries  <tdevries@suse.de>
    
    	* gdb.base/index-cache.exp: Add back missing debug option.

Diff:
---
 gdb/testsuite/ChangeLog                | 4 ++++
 gdb/testsuite/gdb.base/index-cache.exp | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 8410a09..4f23343 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2019-06-26  Tom de Vries  <tdevries@suse.de>
+
+	* gdb.base/index-cache.exp: Add back missing debug option.
+
 2019-06-23  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 
 	* gdb.base/alias.exp: Test non matching/non existing prefixes.
diff --git a/gdb/testsuite/gdb.base/index-cache.exp b/gdb/testsuite/gdb.base/index-cache.exp
index 6f1488e..f14cbb0 100644
--- a/gdb/testsuite/gdb.base/index-cache.exp
+++ b/gdb/testsuite/gdb.base/index-cache.exp
@@ -19,7 +19,7 @@
 standard_testfile
 
 if { [prepare_for_testing "failed to prepare" $testfile $srcfile \
-	  {additional_flags=-Wl,--build-id}] } {
+	  {debug additional_flags=-Wl,--build-id}] } {
     return
 }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-06-26  3:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-26  3:53 [binutils-gdb] [gdb/testsuite] Add back missing debug for index-cache.exp Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).