From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29596 invoked by alias); 26 Jun 2019 15:53:05 -0000 Mailing-List: contact gdb-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: , Sender: gdb-cvs-owner@sourceware.org List-Subscribe: Sender: gdb-cvs-owner@sourceware.org Received: (qmail 29550 invoked by uid 306); 26 Jun 2019 15:53:05 -0000 Date: Wed, 26 Jun 2019 15:53:00 -0000 Message-ID: <20190626155305.29548.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove lookup_minimal_symbol_solib_trampoline X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: aa2f9bcf23a00fc7e9d7350757b8938c36106c42 X-Git-Newrev: 762c164d754fc456aa4764d2ed19cc4a3ec625fb X-SW-Source: 2019-06/txt/msg00211.txt.bz2 https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=762c164d754fc456aa4764d2ed19cc4a3ec625fb commit 762c164d754fc456aa4764d2ed19cc4a3ec625fb Author: Tom Tromey Date: Wed Jun 26 09:48:32 2019 -0600 Remove lookup_minimal_symbol_solib_trampoline lookup_minimal_symbol_solib_trampoline is unused, so this patch removes it. The last use was apparently removed in commit 61a12cfa ("Remove HPUX"). gdb/ChangeLog 2019-06-26 Tom Tromey * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove. * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't declare. Diff: --- gdb/ChangeLog | 6 ++++++ gdb/minsyms.c | 34 ---------------------------------- gdb/minsyms.h | 12 ------------ 3 files changed, 6 insertions(+), 46 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 04a9ebc..f06d13e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2019-06-26 Tom Tromey + + * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove. + * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't + declare. + 2019-06-26 Alan Hayward * features/aarch64-core.c (create_feature_aarch64_core): diff --git a/gdb/minsyms.c b/gdb/minsyms.c index 9d29d88..e64e5df 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -597,40 +597,6 @@ lookup_minimal_symbol_by_pc_name (CORE_ADDR pc, const char *name, return NULL; } -/* See minsyms.h. */ - -struct bound_minimal_symbol -lookup_minimal_symbol_solib_trampoline (const char *name, - struct objfile *objf) -{ - struct minimal_symbol *msymbol; - struct bound_minimal_symbol found_symbol = { NULL, NULL }; - - unsigned int hash = msymbol_hash (name) % MINIMAL_SYMBOL_HASH_SIZE; - - for (objfile *objfile : current_program_space->objfiles ()) - { - if (objf == NULL || objf == objfile - || objf == objfile->separate_debug_objfile_backlink) - { - for (msymbol = objfile->per_bfd->msymbol_hash[hash]; - msymbol != NULL; - msymbol = msymbol->hash_next) - { - if (strcmp (MSYMBOL_LINKAGE_NAME (msymbol), name) == 0 && - MSYMBOL_TYPE (msymbol) == mst_solib_trampoline) - { - found_symbol.objfile = objfile; - found_symbol.minsym = msymbol; - return found_symbol; - } - } - } - } - - return found_symbol; -} - /* A helper function that makes *PC section-relative. This searches the sections of OBJFILE and if *PC is in a section, it subtracts the section offset and returns true. Otherwise it returns diff --git a/gdb/minsyms.h b/gdb/minsyms.h index 3e414f6..bb43165 100644 --- a/gdb/minsyms.h +++ b/gdb/minsyms.h @@ -205,18 +205,6 @@ struct bound_minimal_symbol lookup_minimal_symbol_text (const char *, struct objfile *); /* Look through all the current minimal symbol tables and find the - first minimal symbol that matches NAME and is a solib trampoline. - If OBJF is non-NULL, limit the search to that objfile. Returns a - pointer to the minimal symbol that matches, or NULL if no match is - found. - - This function only searches the mangled (linkage) names. */ - -struct bound_minimal_symbol lookup_minimal_symbol_solib_trampoline - (const char *, - struct objfile *); - -/* Look through all the current minimal symbol tables and find the first minimal symbol that matches NAME and PC. If OBJF is non-NULL, limit the search to that objfile. Returns a pointer to the minimal symbol that matches, or NULL if no match is found. */