public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Remove return value from remove_breakpoints_inf
Date: Wed, 03 Jul 2019 02:09:00 -0000	[thread overview]
Message-ID: <20190703020908.8648.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f3869b1a41a809f208b964ee00cea74bd905b75f

commit f3869b1a41a809f208b964ee00cea74bd905b75f
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Tue Jul 2 22:03:09 2019 -0400

    Remove return value from remove_breakpoints_inf
    
    ... since nobody uses it.
    
    gdb/ChangeLog:
    
    	* breakpoint.h (remove_breakpoints_inf): Change return type to
    	void, move function documentation here.
    	* breakpoint.c (remove_breakpoints_inf): Change return type to
    	void, move function documentation to header.

Diff:
---
 gdb/ChangeLog    | 7 +++++++
 gdb/breakpoint.c | 7 +++----
 gdb/breakpoint.h | 4 +++-
 3 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 35f1bae..d50fe89 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
+
+	* breakpoint.h (remove_breakpoints_inf): Change return type to
+	void, move function documentation here.
+	* breakpoint.c (remove_breakpoints_inf): Change return type to
+	void, move function documentation to header.
+
 2019-07-02  Pedro Alves  <palves@redhat.com>
 
 	* NEWS (Completion improvements): Mention "info threads".
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 8422db8..b49be76 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -3049,9 +3049,9 @@ Thread-specific breakpoint %d deleted - thread %s no longer in the thread list.\
     }
 }
 
-/* Remove breakpoints of inferior INF.  */
+/* See breakpoint.h.  */
 
-int
+void
 remove_breakpoints_inf (inferior *inf)
 {
   struct bp_location *bl, **blp_tmp;
@@ -3066,10 +3066,9 @@ remove_breakpoints_inf (inferior *inf)
       {
 	val = remove_breakpoint (bl);
 	if (val != 0)
-	  return val;
+	  return;
       }
   }
-  return 0;
 }
 
 static int internal_breakpoint_number = -1;
diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
index 9068031..75f1978 100644
--- a/gdb/breakpoint.h
+++ b/gdb/breakpoint.h
@@ -1390,7 +1390,9 @@ extern void insert_breakpoints (void);
 
 extern int remove_breakpoints (void);
 
-extern int remove_breakpoints_inf (inferior *inf);
+/* Remove breakpoints of inferior INF.  */
+
+extern void remove_breakpoints_inf (inferior *inf);
 
 /* This function can be used to update the breakpoint package's state
    after an exec() system call has been executed.


                 reply	other threads:[~2019-07-03  2:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190703020908.8648.qmail@sourceware.org \
    --to=simark@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).