From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108581 invoked by alias); 15 Jul 2019 15:36:41 -0000 Mailing-List: contact gdb-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: , Sender: gdb-cvs-owner@sourceware.org List-Subscribe: Sender: gdb-cvs-owner@sourceware.org Received: (qmail 107700 invoked by uid 306); 15 Jul 2019 15:36:41 -0000 Date: Mon, 15 Jul 2019 15:36:00 -0000 Message-ID: <20190715153641.107699.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Fix a FIXME in mi-out.c X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 1f77b012e61ec11c92a35223fdfed598c6d2f4e9 X-Git-Newrev: 07128006d6caec5df31a960b131d2026f35ed948 X-SW-Source: 2019-07/txt/msg00078.txt.bz2 https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=07128006d6caec5df31a960b131d2026f35ed948 commit 07128006d6caec5df31a960b131d2026f35ed948 Author: Tom Tromey Date: Tue Jul 2 09:13:53 2019 -0600 Fix a FIXME in mi-out.c This removes a FIXME comment from mi_ui_out::do_field_int, by replacing a printf with a use of plongest. 2019-07-15 Tom Tromey * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest. Diff: --- gdb/ChangeLog | 4 ++++ gdb/mi/mi-out.c | 5 +---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1b08595..bb2e8d1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2019-07-15 Tom Tromey + * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest. + +2019-07-15 Tom Tromey + * mi/mi-out.h (class mi_ui_out) : Declare. * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method. * cli-out.h (class cli_ui_out) : Declare. diff --git a/gdb/mi/mi-out.c b/gdb/mi/mi-out.c index dd99a2b..75e3f03 100644 --- a/gdb/mi/mi-out.c +++ b/gdb/mi/mi-out.c @@ -98,10 +98,7 @@ void mi_ui_out::do_field_int (int fldno, int width, ui_align alignment, const char *fldname, int value) { - char buffer[20]; /* FIXME: how many chars long a %d can become? */ - - xsnprintf (buffer, sizeof (buffer), "%d", value); - do_field_string (fldno, width, alignment, fldname, buffer, + do_field_string (fldno, width, alignment, fldname, plongest (value), ui_out_style_kind::DEFAULT); }