public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix typo in tcl_version_at_least
@ 2019-08-05 10:52 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2019-08-05 10:52 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d09628385443574b556f2beaaba7588a2a5fb4c0
commit d09628385443574b556f2beaaba7588a2a5fb4c0
Author: Tom de Vries <tdevries@suse.de>
Date: Mon Aug 5 12:51:58 2019 +0200
[gdb/testsuite] Fix typo in tcl_version_at_least
In tcl_version_at_least we compare a minor against a major version number:
...
} elseif { $tcl_version_major == $major \
&& $tcl_version_major >= $minor } {
...
Fix this by using $tcl_version_minor in the comparison instead.
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2019-08-05 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (tcl_version_at_least): Fix typo.
Diff:
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/lib/gdb.exp | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index fe156ea..b53913c 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2019-08-05 Tom de Vries <tdevries@suse.de>
+
+ * lib/gdb.exp (tcl_version_at_least): Fix typo.
+
2019-08-04 Sandra Loosemore <sandra@codesourcery.com>
* gdb.server/reconnect-ctrl-c.exp: Skip if nointerrupts.
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 9ca34d8..6d16217 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -1111,7 +1111,7 @@ proc tcl_version_at_least { major minor } {
if { $tcl_version_major > $major } {
return 1
} elseif { $tcl_version_major == $major \
- && $tcl_version_major >= $minor } {
+ && $tcl_version_minor >= $minor } {
return 1
} else {
return 0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-08-05 10:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05 10:52 [binutils-gdb] [gdb/testsuite] Fix typo in tcl_version_at_least Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).