public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Remove NULL check from tui_reg_command
@ 2019-08-20 22:49 Tom Tromey
  0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2019-08-20 22:49 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0f8d8876d98305671a19b5bf88f125d4d02c7e0f

commit 0f8d8876d98305671a19b5bf88f125d4d02c7e0f
Author: Tom Tromey <tom@tromey.com>
Date:   Sat Jul 13 15:53:44 2019 -0600

    Remove NULL check from tui_reg_command
    
    tui_reg_command has an unnecessary NULL check.  The preceding call to
    tui_reg_layout will ensure the window exists.  This patch removes the
    check.
    
    gdb/ChangeLog
    2019-08-20  Tom Tromey  <tom@tromey.com>
    
    	* tui/tui-regs.c (tui_reg_command): Remove NULL check.

Diff:
---
 gdb/ChangeLog      | 4 ++++
 gdb/tui/tui-regs.c | 4 +---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c4a1179..ce64e7a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2019-08-20  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui-regs.c (tui_reg_command): Remove NULL check.
+
+2019-08-20  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui-source.h (struct tui_source_window): Update.
 	* tui/tui-regs.c (tui_show_registers): Update.
 	* tui/tui-disasm.h (struct tui_disasm_window): Update.
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 8fcb7bc..b3c7ce6 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -669,9 +669,7 @@ tui_reg_command (const char *args, int from_tty)
       if (TUI_DATA_WIN == NULL || !TUI_DATA_WIN->is_visible ())
 	tui_reg_layout ();
 
-      struct reggroup *current_group = NULL;
-      if (TUI_DATA_WIN != NULL)
-	current_group = TUI_DATA_WIN->current_group;
+      struct reggroup *current_group = TUI_DATA_WIN->current_group;
       if (strncmp (args, "next", len) == 0)
 	match = tui_reg_next (current_group, gdbarch);
       else if (strncmp (args, "prev", len) == 0)


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-08-20 22:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 22:49 [binutils-gdb] Remove NULL check from tui_reg_command Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).