From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101567 invoked by alias); 30 Aug 2019 21:05:53 -0000 Mailing-List: contact gdb-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: , Sender: gdb-cvs-owner@sourceware.org List-Subscribe: Sender: gdb-cvs-owner@sourceware.org Received: (qmail 101524 invoked by uid 9813); 30 Aug 2019 21:05:53 -0000 Date: Fri, 30 Aug 2019 21:05:00 -0000 Message-ID: <20190830210553.101522.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Sergio Durigan Junior To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove "\nError: " suffix from nat/fork-inferior.c:trace_start_error warning message X-Act-Checkin: binutils-gdb X-Git-Author: Sergio Durigan Junior X-Git-Refname: refs/heads/master X-Git-Oldrev: d6a00eba2accffec92a5974c2ad1f79612a6679e X-Git-Newrev: 47a536d940d2f2bccfec51539b857da06ebc429e X-SW-Source: 2019-08/txt/msg00184.txt.bz2 https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=47a536d940d2f2bccfec51539b857da06ebc429e commit 47a536d940d2f2bccfec51539b857da06ebc429e Author: Sergio Durigan Junior Date: Thu Aug 29 16:11:45 2019 -0400 Remove "\nError: " suffix from nat/fork-inferior.c:trace_start_error warning message Rationale: https://sourceware.org/ml/gdb-patches/2019-08/msg00651.html This very simple patch removes the "\nError: " suffix from the warning message printed by nat/fork-inferior.c:trace_start_error. This proved to just pollute the screen, causing things like: Starting program: /usr/bin/true warning: Could not trace the inferior process. Error: warning: ptrace: Permission denied This "Error: " string is not useful at all, and can confuse things, therefore let's just remove it and simplify the resulting messages: Starting program: /usr/bin/true warning: Could not trace the inferior process. warning: ptrace: Permission denied gdb/ChangeLog: 2019-08-30 Sergio Durigan Junior * nat/fork-inferior.c (trace_start_error): Remove "\nError: " suffix from warning message. Diff: --- gdb/ChangeLog | 5 +++++ gdb/nat/fork-inferior.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2cc7b58..ebcfae1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-08-30 Sergio Durigan Junior + + * nat/fork-inferior.c (trace_start_error): Remove "\nError: " + suffix from warning message. + 2019-08-30 Tom Tromey * tui/tui-winsource.h (struct tui_source_window_base) diff --git a/gdb/nat/fork-inferior.c b/gdb/nat/fork-inferior.c index 68b51aa..355e9be 100644 --- a/gdb/nat/fork-inferior.c +++ b/gdb/nat/fork-inferior.c @@ -580,7 +580,7 @@ trace_start_error (const char *fmt, ...) va_list ap; va_start (ap, fmt); - warning ("Could not trace the inferior process.\nError: "); + warning ("Could not trace the inferior process."); vwarning (fmt, ap); va_end (ap);