public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Use make_unique_xstrdup in TUI
@ 2019-09-20 20:07 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2019-09-20 20:07 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f074b67ec812612637342a1647da9158a1e77de0
commit f074b67ec812612637342a1647da9158a1e77de0
Author: Tom Tromey <tom@tromey.com>
Date: Tue Sep 10 12:56:09 2019 -0600
Use make_unique_xstrdup in TUI
This changes a couple of spots in the TUI to use make_unique_xstrdup.
This simplifies the code slightly.
gdb/ChangeLog
2019-09-20 Tom Tromey <tom@tromey.com>
* tui/tui-source.c (tui_source_window::set_contents): Use
make_unique_xstrdup.
* tui/tui-disasm.c (tui_disasm_window::set_contents): Use
make_unique_xstrdup.
Diff:
---
gdb/ChangeLog | 7 +++++++
gdb/tui/tui-disasm.c | 2 +-
gdb/tui/tui-source.c | 2 +-
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8f69dc5..402b57a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,12 @@
2019-09-20 Tom Tromey <tom@tromey.com>
+ * tui/tui-source.c (tui_source_window::set_contents): Use
+ make_unique_xstrdup.
+ * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
+ make_unique_xstrdup.
+
+2019-09-20 Tom Tromey <tom@tromey.com>
+
* tui/tui-data.c: Remove separator comments.
* tui/tui-layout.c: Remove separator comments.
* tui/tui-win.c: Remove separator comments.
diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c
index 53ea061..51616bc 100644
--- a/gdb/tui/tui-disasm.c
+++ b/gdb/tui/tui-disasm.c
@@ -218,7 +218,7 @@ tui_disasm_window::set_contents (struct gdbarch *arch,
if (line.size() > offset)
src->line.reset (xstrndup (&line[offset], line_width));
else
- src->line.reset (xstrdup (""));
+ src->line = make_unique_xstrdup ("");
src->line_or_addr.loa = LOA_ADDRESS;
src->line_or_addr.u.addr = asm_lines[i].addr;
diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
index fa6ed78..bb1013b 100644
--- a/gdb/tui/tui-source.c
+++ b/gdb/tui/tui-source.c
@@ -183,7 +183,7 @@ tui_source_window::set_contents (struct gdbarch *arch,
symtab_to_fullname (s)) == 0
&& cur_line_no == locator->line_no);
- content[cur_line].line.reset (xstrdup (text.c_str ()));
+ content[cur_line].line = make_unique_xstrdup (text.c_str ());
cur_line++;
cur_line_no++;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-09-20 20:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-20 20:07 [binutils-gdb] Use make_unique_xstrdup in TUI Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).