From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70999 invoked by alias); 20 Sep 2019 20:07:18 -0000 Mailing-List: contact gdb-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: , Sender: gdb-cvs-owner@sourceware.org List-Subscribe: Sender: gdb-cvs-owner@sourceware.org Received: (qmail 70981 invoked by uid 306); 20 Sep 2019 20:07:18 -0000 Date: Fri, 20 Sep 2019 20:07:00 -0000 Message-ID: <20190920200718.70980.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Use make_unique_xstrdup in TUI X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 63c4bf1922d5553edb213606270b0e2782bbe4c8 X-Git-Newrev: f074b67ec812612637342a1647da9158a1e77de0 X-SW-Source: 2019-09/txt/msg00092.txt.bz2 https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f074b67ec812612637342a1647da9158a1e77de0 commit f074b67ec812612637342a1647da9158a1e77de0 Author: Tom Tromey Date: Tue Sep 10 12:56:09 2019 -0600 Use make_unique_xstrdup in TUI This changes a couple of spots in the TUI to use make_unique_xstrdup. This simplifies the code slightly. gdb/ChangeLog 2019-09-20 Tom Tromey * tui/tui-source.c (tui_source_window::set_contents): Use make_unique_xstrdup. * tui/tui-disasm.c (tui_disasm_window::set_contents): Use make_unique_xstrdup. Diff: --- gdb/ChangeLog | 7 +++++++ gdb/tui/tui-disasm.c | 2 +- gdb/tui/tui-source.c | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8f69dc5..402b57a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2019-09-20 Tom Tromey + * tui/tui-source.c (tui_source_window::set_contents): Use + make_unique_xstrdup. + * tui/tui-disasm.c (tui_disasm_window::set_contents): Use + make_unique_xstrdup. + +2019-09-20 Tom Tromey + * tui/tui-data.c: Remove separator comments. * tui/tui-layout.c: Remove separator comments. * tui/tui-win.c: Remove separator comments. diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c index 53ea061..51616bc 100644 --- a/gdb/tui/tui-disasm.c +++ b/gdb/tui/tui-disasm.c @@ -218,7 +218,7 @@ tui_disasm_window::set_contents (struct gdbarch *arch, if (line.size() > offset) src->line.reset (xstrndup (&line[offset], line_width)); else - src->line.reset (xstrdup ("")); + src->line = make_unique_xstrdup (""); src->line_or_addr.loa = LOA_ADDRESS; src->line_or_addr.u.addr = asm_lines[i].addr; diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c index fa6ed78..bb1013b 100644 --- a/gdb/tui/tui-source.c +++ b/gdb/tui/tui-source.c @@ -183,7 +183,7 @@ tui_source_window::set_contents (struct gdbarch *arch, symtab_to_fullname (s)) == 0 && cur_line_no == locator->line_no); - content[cur_line].line.reset (xstrdup (text.c_str ())); + content[cur_line].line = make_unique_xstrdup (text.c_str ()); cur_line++; cur_line_no++;