public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Jose E.Marchesi <jemarch@sourceware.org> To: bfd-cvs@sourceware.org, gdb-cvs@sourceware.org Subject: [binutils-gdb] libctf: actually close bfds we have opened Date: Thu, 03 Oct 2019 16:33:00 -0000 [thread overview] Message-ID: <20191003163302.101582.qmail@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f046147d59aab0c8b6f00cd182f34b42ac8915e8 commit f046147d59aab0c8b6f00cd182f34b42ac8915e8 Author: Nick Alcock <nick.alcock@oracle.com> Date: Mon Jul 29 17:02:48 2019 +0100 libctf: actually close bfds we have opened When we do a ctf_fdopen, we open things via bfd_fdopenr and set up a hook to close the bfd again... but then we never actually call that hook from anywhere, so we eventually leak every bfd we open. Fix this by calling the hook (if set) in ctf_arc_close. New in v3. libctf/ * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set. * ctf-open-bfd.c (ctf_bfdclose): Fix comment. Diff: --- libctf/ChangeLog | 5 +++++ libctf/ctf-archive.c | 2 ++ libctf/ctf-open-bfd.c | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/libctf/ChangeLog b/libctf/ChangeLog index 852ad62..ff9e6e5 100644 --- a/libctf/ChangeLog +++ b/libctf/ChangeLog @@ -1,5 +1,10 @@ 2019-07-30 Nick Alcock <nick.alcock@oracle.com> + * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set. + * ctf-open-bfd.c (ctf_bfdclose): Fix comment. + +2019-07-30 Nick Alcock <nick.alcock@oracle.com> + * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable. 2019-07-13 Nick Alcock <nick.alcock@oracle.com> diff --git a/libctf/ctf-archive.c b/libctf/ctf-archive.c index 8de11d6..979641c 100644 --- a/libctf/ctf-archive.c +++ b/libctf/ctf-archive.c @@ -436,6 +436,8 @@ ctf_arc_close (ctf_archive_t *arc) free ((void *) arc->ctfi_symsect.cts_data); /* Do not free the ctfi_strsect: it is bound to the bfd. */ free (arc->ctfi_data); + if (arc->ctfi_bfd_close) + arc->ctfi_bfd_close (arc); free (arc); } diff --git a/libctf/ctf-open-bfd.c b/libctf/ctf-open-bfd.c index 1083c87..d17b72d 100644 --- a/libctf/ctf-open-bfd.c +++ b/libctf/ctf-open-bfd.c @@ -66,7 +66,7 @@ ctf_new_archive_internal (int is_archive, struct ctf_archive *arc, return arci; } -/* Free the BFD bits of a CTF file on ctf_file_close(). */ +/* Free the BFD bits of a CTF file on ctf_arc_close(). */ static void ctf_bfdclose (struct ctf_archive_internal *arci)
reply other threads:[~2019-10-03 16:33 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191003163302.101582.qmail@sourceware.org \ --to=jemarch@sourceware.org \ --cc=bfd-cvs@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).