public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix local-static.exp with gcc-4.8
@ 2019-10-04 14:23 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2019-10-04 14:23 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4dbbb47c168a617ce27c1bdb05ebbd7842fceada

commit 4dbbb47c168a617ce27c1bdb05ebbd7842fceada
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Oct 4 16:23:24 2019 +0200

    [gdb/testsuite] Fix local-static.exp with gcc-4.8
    
    With gdb.cp/local-static.exp and gcc 4.8, I see:
    ...
    gdb compile failed, src/gdb/testsuite/gdb.cp/local-static.c: In function 'main':
    src/gdb/testsuite/gdb.cp/local-static.c:148:3: error: 'for' loop initial \
      declarations are only allowed in C99 mode
       for (int i = 0; i < 1000; i++)
       ^
    src/gdb/testsuite/gdb.cp/local-static.c:148:3: note: use option -std=c99 or \
      -std=gnu99 to compile your code
    UNTESTED: gdb.cp/local-static.exp: c: failed to prepare
    ...
    
    Fix this by moving the declaration of int i out of the for loop.
    
    gdb/testsuite/ChangeLog:
    
    2019-10-04  Tom de Vries  <tdevries@suse.de>
    
    	* gdb.cp/local-static.c (main): Move declaration of int i out of the
    	for loop.

Diff:
---
 gdb/testsuite/ChangeLog             | 5 +++++
 gdb/testsuite/gdb.cp/local-static.c | 4 +++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index f42a0a3c..0eeb8c6 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-10-04  Tom de Vries  <tdevries@suse.de>
+
+	* gdb.cp/local-static.c (main): Move declaration of int i out of the
+	for loop.
+
 2019-10-03  Tom Tromey  <tom@tromey.com>
 
 	PR rust/24976:
diff --git a/gdb/testsuite/gdb.cp/local-static.c b/gdb/testsuite/gdb.cp/local-static.c
index 33ab2e3..6d9c368 100644
--- a/gdb/testsuite/gdb.cp/local-static.c
+++ b/gdb/testsuite/gdb.cp/local-static.c
@@ -145,7 +145,9 @@ free_inline_func (void)
 int
 main ()
 {
-  for (int i = 0; i < 1000; i++)
+  int i;
+
+  for (i = 0; i < 1000; i++)
     {
       free_func ();
       free_inline_func ();


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-10-04 14:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-04 14:23 [binutils-gdb] [gdb/testsuite] Fix local-static.exp with gcc-4.8 Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).