public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Christian Biesinger <cbiesinger@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Move declaration of varobjdebug to header
Date: Thu, 10 Oct 2019 17:40:00 -0000	[thread overview]
Message-ID: <20191010174046.41158.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c2c440a9038acc7b94ffbc83f4711dbf08b582a9

commit c2c440a9038acc7b94ffbc83f4711dbf08b582a9
Author: Christian Biesinger <cbiesinger@google.com>
Date:   Wed Oct 9 23:06:14 2019 -0500

    Move declaration of varobjdebug to header
    
    gdb/ChangeLog:
    
    2019-10-10  Christian Biesinger  <cbiesinger@google.com>
    
    	* mi/mi-cmd-var.c (varobjdebug): Remove declaration.
    	* varobj.c (varobjdebug): Move comment to...
    	* varobj.h (varobjdebug): ...here, and declare.

Diff:
---
 gdb/ChangeLog       | 6 ++++++
 gdb/mi/mi-cmd-var.c | 2 --
 gdb/varobj.c        | 2 +-
 gdb/varobj.h        | 5 +++++
 4 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a5504a9..2abae43 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2019-10-10  Christian Biesinger  <cbiesinger@google.com>
+
+	* mi/mi-cmd-var.c (varobjdebug): Remove declaration.
+	* varobj.c (varobjdebug): Move comment to...
+	* varobj.h (varobjdebug): ...here, and declare.
+
 2019-10-09  Tom Tromey  <tom@tromey.com>
 
 	* tui/tui-regs.c (tui_data_window::show_registers): Don't call
diff --git a/gdb/mi/mi-cmd-var.c b/gdb/mi/mi-cmd-var.c
index f5219e0..d1de382 100644
--- a/gdb/mi/mi-cmd-var.c
+++ b/gdb/mi/mi-cmd-var.c
@@ -33,8 +33,6 @@
 #include "gdbsupport/gdb_optional.h"
 #include "inferior.h"
 
-extern unsigned int varobjdebug;		/* defined in varobj.c.  */
-
 static void varobj_update_one (struct varobj *var,
 			       enum print_values print_values,
 			       bool is_explicit);
diff --git a/gdb/varobj.c b/gdb/varobj.c
index 8090068..827a1b0 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -40,7 +40,7 @@
 typedef int PyObject;
 #endif
 
-/* Non-zero if we want to see trace of varobj level stuff.  */
+/* See varobj.h.  */
 
 unsigned int varobjdebug = 0;
 static void
diff --git a/gdb/varobj.h b/gdb/varobj.h
index 9067d2d..8f00d78 100644
--- a/gdb/varobj.h
+++ b/gdb/varobj.h
@@ -235,6 +235,11 @@ extern const struct lang_varobj_ops cplus_varobj_ops;
 extern const struct lang_varobj_ops ada_varobj_ops;
 
 #define default_varobj_ops c_varobj_ops
+
+/* Non-zero if we want to see trace of varobj level stuff.  */
+
+extern unsigned int varobjdebug;
+
 /* API functions */
 
 extern struct varobj *varobj_create (const char *objname,


                 reply	other threads:[~2019-10-10 17:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191010174046.41158.qmail@sourceware.org \
    --to=cbiesinger@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).