public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Christian Biesinger <cbiesinger@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Remove unnecessary declaration of trace_regblock_size
Date: Sat, 12 Oct 2019 23:36:00 -0000	[thread overview]
Message-ID: <20191012233638.54544.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7b9a15e1ee822aea78d546ec8fafcafd27ee6de0

commit 7b9a15e1ee822aea78d546ec8fafcafd27ee6de0
Author: Christian Biesinger <cbiesinger@google.com>
Date:   Thu Oct 10 22:57:36 2019 -0500

    Remove unnecessary declaration of trace_regblock_size
    
    This variable is declared in tracepoint.h, which is already included
    by remote.c.
    
    gdb/ChangeLog:
    
    2019-10-12  Christian Biesinger  <cbiesinger@google.com>
    
    	* remote.c (remote_target::get_trace_status): Remove declaration of
    	trace_regblock_size.

Diff:
---
 gdb/ChangeLog | 5 +++++
 gdb/remote.c  | 3 +--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d58a55f..e6e1489 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 
+	* remote.c (remote_target::get_trace_status): Remove declaration of
+	trace_regblock_size.
+
+2019-10-12  Christian Biesinger  <cbiesinger@google.com>
+
 	* cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 	(show_user): Remove declaration of cmdlist.
 	* cli/cli-cmds.h (max_user_call_depth): Declare.
diff --git a/gdb/remote.c b/gdb/remote.c
index 21160e1..73b510d 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -13102,14 +13102,13 @@ remote_target::get_trace_status (struct trace_status *ts)
 {
   /* Initialize it just to avoid a GCC false warning.  */
   char *p = NULL;
-  /* FIXME we need to get register block size some other way.  */
-  extern int trace_regblock_size;
   enum packet_result result;
   struct remote_state *rs = get_remote_state ();
 
   if (packet_support (PACKET_qTStatus) == PACKET_DISABLE)
     return -1;
 
+  /* FIXME we need to get register block size some other way.  */
   trace_regblock_size
     = rs->get_remote_arch_state (target_gdbarch ())->sizeof_g_packet;


                 reply	other threads:[~2019-10-12 23:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191012233638.54544.qmail@sourceware.org \
    --to=cbiesinger@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).