public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Remove unnecessary declaration of trace_regblock_size
@ 2019-10-12 23:36 Christian Biesinger
0 siblings, 0 replies; only message in thread
From: Christian Biesinger @ 2019-10-12 23:36 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7b9a15e1ee822aea78d546ec8fafcafd27ee6de0
commit 7b9a15e1ee822aea78d546ec8fafcafd27ee6de0
Author: Christian Biesinger <cbiesinger@google.com>
Date: Thu Oct 10 22:57:36 2019 -0500
Remove unnecessary declaration of trace_regblock_size
This variable is declared in tracepoint.h, which is already included
by remote.c.
gdb/ChangeLog:
2019-10-12 Christian Biesinger <cbiesinger@google.com>
* remote.c (remote_target::get_trace_status): Remove declaration of
trace_regblock_size.
Diff:
---
gdb/ChangeLog | 5 +++++
gdb/remote.c | 3 +--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d58a55f..e6e1489 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2019-10-12 Christian Biesinger <cbiesinger@google.com>
+ * remote.c (remote_target::get_trace_status): Remove declaration of
+ trace_regblock_size.
+
+2019-10-12 Christian Biesinger <cbiesinger@google.com>
+
* cli/cli-cmds.c (max_user_call_depth): Move comment to header.
(show_user): Remove declaration of cmdlist.
* cli/cli-cmds.h (max_user_call_depth): Declare.
diff --git a/gdb/remote.c b/gdb/remote.c
index 21160e1..73b510d 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -13102,14 +13102,13 @@ remote_target::get_trace_status (struct trace_status *ts)
{
/* Initialize it just to avoid a GCC false warning. */
char *p = NULL;
- /* FIXME we need to get register block size some other way. */
- extern int trace_regblock_size;
enum packet_result result;
struct remote_state *rs = get_remote_state ();
if (packet_support (PACKET_qTStatus) == PACKET_DISABLE)
return -1;
+ /* FIXME we need to get register block size some other way. */
trace_regblock_size
= rs->get_remote_arch_state (target_gdbarch ())->sizeof_g_packet;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-10-12 23:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-12 23:36 [binutils-gdb] Remove unnecessary declaration of trace_regblock_size Christian Biesinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).