public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix regexp for reg value in jit-reader.exp
@ 2019-10-16 14:53 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2019-10-16 14:53 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b17fcc10396991b4b095c279672398a9c54c03ab
commit b17fcc10396991b4b095c279672398a9c54c03ab
Author: Tom de Vries <tdevries@suse.de>
Date: Wed Oct 16 16:53:37 2019 +0200
[gdb/testsuite] Fix regexp for reg value in jit-reader.exp
On openSUSE Leap 15.1 (as well as on Fedora-x86_64-m64 buildbot) I see:
...
FAIL: gdb.base/jit-reader.exp: with jit-reader: after mangling: current frame: info registers
...
The problem is that r10 is printed signed:
...
r10 0xffffffffffffffb0 -80^M
...
but the regexp expects a signed value:
...
"r10 $hex +$decimal" \
...
Fix this by allowing signed values.
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2019-10-16 Tom de Vries <tdevries@suse.de>
* gdb.base/jit-reader.exp: Allow non-pointer registers to be printed
as signed.
Change-Id: Ie494d24fad7a9af7ac6bfaf731c4aa04f1333830
Diff:
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.base/jit-reader.exp | 41 ++++++++++++++++++-----------------
2 files changed, 26 insertions(+), 20 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index ce6e0f2..c9e2457 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-10-16 Tom de Vries <tdevries@suse.de>
+
+ * gdb.base/jit-reader.exp: Allow non-pointer registers to be printed
+ as signed.
+
2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
* gdb.mi/list-thread-groups-available.exp: Read entries one by
diff --git a/gdb/testsuite/gdb.base/jit-reader.exp b/gdb/testsuite/gdb.base/jit-reader.exp
index 7c07c16..1ef3341 100644
--- a/gdb/testsuite/gdb.base/jit-reader.exp
+++ b/gdb/testsuite/gdb.base/jit-reader.exp
@@ -65,32 +65,33 @@ proc info_registers_current_frame {sp} {
set any "\[^\r\n\]*"
+ set neg_decimal "-?$decimal"
gdb_test "info registers" \
[multi_line \
- "rax $hex +$decimal" \
- "rbx $hex +$decimal" \
- "rcx $hex +$decimal" \
- "rdx $hex +$decimal" \
- "rsi $hex +$decimal" \
- "rdi $hex +$decimal" \
+ "rax $hex +$neg_decimal" \
+ "rbx $hex +$neg_decimal" \
+ "rcx $hex +$neg_decimal" \
+ "rdx $hex +$neg_decimal" \
+ "rsi $hex +$neg_decimal" \
+ "rdi $hex +$neg_decimal" \
"rbp $hex +$hex" \
"rsp $sp +$sp" \
- "r8 $hex +$decimal" \
- "r9 $hex +$decimal" \
- "r10 $hex +$decimal" \
- "r11 $hex +$decimal" \
- "r12 $hex +$decimal" \
- "r13 $hex +$decimal" \
- "r14 $hex +$decimal" \
- "r15 $hex +$decimal" \
+ "r8 $hex +$neg_decimal" \
+ "r9 $hex +$neg_decimal" \
+ "r10 $hex +$neg_decimal" \
+ "r11 $hex +$neg_decimal" \
+ "r12 $hex +$neg_decimal" \
+ "r13 $hex +$neg_decimal" \
+ "r14 $hex +$neg_decimal" \
+ "r15 $hex +$neg_decimal" \
"rip $hex +$hex$any" \
"eflags $hex +\\\[$any\\\]" \
- "cs $hex +$decimal" \
- "ss $hex +$decimal" \
- "ds $hex +$decimal" \
- "es $hex +$decimal" \
- "fs $hex +$decimal" \
- "gs $hex +$decimal" \
+ "cs $hex +$neg_decimal" \
+ "ss $hex +$neg_decimal" \
+ "ds $hex +$neg_decimal" \
+ "es $hex +$neg_decimal" \
+ "fs $hex +$neg_decimal" \
+ "gs $hex +$neg_decimal" \
]
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-10-16 14:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-16 14:53 [binutils-gdb] [gdb/testsuite] Fix regexp for reg value in jit-reader.exp Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).