public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Check for sigprocmask in common.m4
Date: Wed, 23 Oct 2019 15:17:00 -0000	[thread overview]
Message-ID: <20191023151759.120738.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c12d372d263309e2ee81efda713096ea9e62a759

commit c12d372d263309e2ee81efda713096ea9e62a759
Author: Tom Tromey <tom@tromey.com>
Date:   Thu Oct 17 20:51:44 2019 -0600

    Check for sigprocmask in common.m4
    
    I noticed that gdbsupport uses HAVE_SIGPROCMASK, but common.m4 does
    not check for it.  This means that gdbserver may not compile some
    gdbsupport code properly.  This patch fixes this error.
    
    gdb/ChangeLog
    2019-10-23  Tom Tromey  <tom@tromey.com>
    
    	* configure: Rebuild.
    	* configure.ac: Don't check for sigprocmask.
    	* gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
    
    gdb/gdbserver/ChangeLog
    2019-10-23  Tom Tromey  <tom@tromey.com>
    
    	* configure, config.in: Rebuild.
    
    Change-Id: I2c0a4dd2c376507b9483b38707a242382faa8163

Diff:
---
 gdb/ChangeLog            | 6 ++++++
 gdb/configure            | 5 +++--
 gdb/configure.ac         | 2 +-
 gdb/gdbserver/ChangeLog  | 4 ++++
 gdb/gdbserver/config.in  | 3 +++
 gdb/gdbserver/configure  | 3 ++-
 gdb/gdbsupport/common.m4 | 3 ++-
 7 files changed, 21 insertions(+), 5 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0627c1c..fd8c939 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,6 +1,12 @@
 2019-10-23  Tom Tromey  <tom@tromey.com>
 
 	* configure: Rebuild.
+	* configure.ac: Don't check for sigprocmask.
+	* gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
+
+2019-10-23  Tom Tromey  <tom@tromey.com>
+
+	* configure: Rebuild.
 	* acinclude.m4: Use m4_include, not sinclude.
 
 2019-10-23  Tom de Vries  <tdevries@suse.de>
diff --git a/gdb/configure b/gdb/configure
index ae8e451..289c91b 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -13129,7 +13129,7 @@ fi
 for ac_func in getauxval getrusage getuid getgid \
 		pipe poll pread pread64 pwrite resize_term \
 		sbrk getpgid setpgid setpgrp setsid \
-		sigaction sigprocmask sigsetmask socketpair \
+		sigaction sigsetmask socketpair \
 		ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
 		setrlimit getrlimit posix_madvise waitpid \
 		ptrace64 sigaltstack setns use_default_colors
@@ -13538,7 +13538,8 @@ fi
 done
 
 
-  for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction
+  for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \
+		  sigprocmask
 do :
   as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
 ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 6297502..d929b89 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1363,7 +1363,7 @@ AC_FUNC_VFORK
 AC_CHECK_FUNCS([getauxval getrusage getuid getgid \
 		pipe poll pread pread64 pwrite resize_term \
 		sbrk getpgid setpgid setpgrp setsid \
-		sigaction sigprocmask sigsetmask socketpair \
+		sigaction sigsetmask socketpair \
 		ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
 		setrlimit getrlimit posix_madvise waitpid \
 		ptrace64 sigaltstack setns use_default_colors])
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index d48b3de..dcd6238 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,5 +1,9 @@
 2019-10-23  Tom Tromey  <tom@tromey.com>
 
+	* configure, config.in: Rebuild.
+
+2019-10-23  Tom Tromey  <tom@tromey.com>
+
 	* configure: Rebuild.
 	* acinclude.m4: Use m4_include, not sinclude.
 
diff --git a/gdb/gdbserver/config.in b/gdb/gdbserver/config.in
index f05e9be..0bce18d 100644
--- a/gdb/gdbserver/config.in
+++ b/gdb/gdbserver/config.in
@@ -211,6 +211,9 @@
 /* Define to 1 if you have the <signal.h> header file. */
 #undef HAVE_SIGNAL_H
 
+/* Define to 1 if you have the `sigprocmask' function. */
+#undef HAVE_SIGPROCMASK
+
 /* Define if sigsetjmp is available. */
 #undef HAVE_SIGSETJMP
 
diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index 5c84eeb..e513fc5 100755
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -6821,7 +6821,8 @@ fi
 done
 
 
-  for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction
+  for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \
+		  sigprocmask
 do :
   as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
 ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
diff --git a/gdb/gdbsupport/common.m4 b/gdb/gdbsupport/common.m4
index 9038894..471d705 100644
--- a/gdb/gdbsupport/common.m4
+++ b/gdb/gdbsupport/common.m4
@@ -32,7 +32,8 @@ AC_DEFUN([GDB_AC_COMMON], [
 		   termios.h dnl
 		   dlfcn.h)
 
-  AC_CHECK_FUNCS([fdwalk getrlimit pipe pipe2 socketpair sigaction])
+  AC_CHECK_FUNCS([fdwalk getrlimit pipe pipe2 socketpair sigaction \
+		  sigprocmask])
 
   AC_CHECK_DECLS([strerror, strstr])


                 reply	other threads:[~2019-10-23 15:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191023151759.120738.qmail@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).