public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Remove unused includes in infcmd.c and infrun.c
Date: Tue, 29 Oct 2019 21:55:00 -0000	[thread overview]
Message-ID: <20191029215527.42804.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f18ad8a16b71a1d4da122e63473966e834447f28

commit f18ad8a16b71a1d4da122e63473966e834447f28
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Tue Oct 29 17:54:35 2019 -0400

    Remove unused includes in infcmd.c and infrun.c
    
    include-what-you-use reported this:
    
    ../../../src/binutils-gdb/gdb/infcmd.c should remove these lines:
    - #include <signal.h>  // lines 22-22
    - #include "cli/cli-decode.h"  // lines 48-48
    - #include "cli/cli-utils.h"  // lines 56-56
    - #include "event-top.h"  // lines 38-38
    - #include "infcall.h"  // lines 57-57
    - #include "parser-defs.h"  // lines 39-39
    
    ../../../src/binutils-gdb/gdb/infrun.c should remove these lines:
    - #include <signal.h>  // lines 37-37
    - #include "cli/cli-script.h"  // lines 31-31
    - #include "continuations.h"  // lines 54-54
    - #include "dictionary.h"  // lines 45-45
    - #include "gdbsupport/gdb_wait.h"  // lines 28-28
    - #include "interps.h"  // lines 55-55
    
    Remove those includes.
    
    Tested by rebuilding, and by quick inspection that the include fields
    were indeed unnecessary.
    
    gdb/ChangeLog:
    
    	* infcmd.c: Remove includes.
    	* infrun.c: Remove includes.
    
    Change-Id: I5e25af54ecd2235960c4127add8f604ddbb19153

Diff:
---
 gdb/ChangeLog | 5 +++++
 gdb/infcmd.c  | 6 ------
 gdb/infrun.c  | 6 ------
 3 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8c12df0..7338ec3 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 
+	* infcmd.c: Remove includes.
+	* infrun.c: Remove includes.
+
+2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
+
 	* ada-lang.h (GROW_VECT): Move to ada-lang.c.
 	(grow_vect): Remove declaration.
 	(ada_type_of_array): Remove declaration.
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index 465d3a1..5ca9933 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -19,7 +19,6 @@
 
 #include "defs.h"
 #include "arch-utils.h"
-#include <signal.h>
 #include "symtab.h"
 #include "gdbtypes.h"
 #include "frame.h"
@@ -35,8 +34,6 @@
 #include "objfiles.h"
 #include "completer.h"
 #include "ui-out.h"
-#include "event-top.h"
-#include "parser-defs.h"
 #include "regcache.h"
 #include "reggroups.h"
 #include "block.h"
@@ -45,7 +42,6 @@
 #include "observable.h"
 #include "target-descriptions.h"
 #include "user-regs.h"
-#include "cli/cli-decode.h"
 #include "gdbthread.h"
 #include "valprint.h"
 #include "inline-frame.h"
@@ -53,8 +49,6 @@
 #include "inf-loop.h"
 #include "continuations.h"
 #include "linespec.h"
-#include "cli/cli-utils.h"
-#include "infcall.h"
 #include "thread-fsm.h"
 #include "top.h"
 #include "interps.h"
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 66a066f..d8a6eed 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -25,16 +25,13 @@
 #include "frame.h"
 #include "inferior.h"
 #include "breakpoint.h"
-#include "gdbsupport/gdb_wait.h"
 #include "gdbcore.h"
 #include "gdbcmd.h"
-#include "cli/cli-script.h"
 #include "target.h"
 #include "gdbthread.h"
 #include "annotate.h"
 #include "symfile.h"
 #include "top.h"
-#include <signal.h>
 #include "inf-loop.h"
 #include "regcache.h"
 #include "value.h"
@@ -42,7 +39,6 @@
 #include "language.h"
 #include "solib.h"
 #include "main.h"
-#include "dictionary.h"
 #include "block.h"
 #include "mi/mi-common.h"
 #include "event-top.h"
@@ -51,8 +47,6 @@
 #include "inline-frame.h"
 #include "jit.h"
 #include "tracepoint.h"
-#include "continuations.h"
-#include "interps.h"
 #include "skip.h"
 #include "probe.h"
 #include "objfiles.h"


                 reply	other threads:[~2019-10-29 21:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029215527.42804.qmail@sourceware.org \
    --to=simark@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).