public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Update comments about removed function
@ 2020-01-24 11:35 Christian Biesinger
  0 siblings, 0 replies; only message in thread
From: Christian Biesinger @ 2020-01-24 11:35 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=89203d40625ea3c835a19c8a4aff8bdeff479748

commit 89203d40625ea3c835a19c8a4aff8bdeff479748
Author: Christian Biesinger <cbiesinger@google.com>
Date:   Thu Jan 23 15:52:05 2020 +0100

    Update comments about removed function
    
    regset_from_core_section doesn't exist anymore; it has been replaced
    by the iterate_over_regset_sections gdbarch method.  Update comments
    accordingly to not confuse readers.
    
    gdb/ChangeLog:
    
    2020-01-24  Christian Biesinger  <cbiesinger@google.com>
    
    	* aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
    	Update comment.
    	* aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
    	Likewise.
    	* arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
    	* gdbcore.h (deprecated_add_core_fns): Update comment to point to
    	the correct replacement (iterate_over_regset_sections).
    	* riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
    	Update comment.
    
    Change-Id: I5eea4d18e15edae5d6dfd5d0d6241e5b2ae40daa

Diff:
---
 gdb/ChangeLog            | 12 ++++++++++++
 gdb/aarch64-fbsd-tdep.c  |  2 +-
 gdb/aarch64-linux-tdep.c |  2 +-
 gdb/arm-fbsd-tdep.c      |  2 +-
 gdb/gdbcore.h            |  3 +--
 gdb/riscv-fbsd-tdep.c    |  2 +-
 6 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ca2e49e..964a01d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,15 @@
+2020-01-24  Christian Biesinger  <cbiesinger@google.com>
+
+	* aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
+	Update comment.
+	* aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
+	Likewise.
+	* arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
+	* gdbcore.h (deprecated_add_core_fns): Update comment to point to
+	the correct replacement (iterate_over_regset_sections).
+	* riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
+	Update comment.
+
 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
 
 	PR gdb/23718
diff --git a/gdb/aarch64-fbsd-tdep.c b/gdb/aarch64-fbsd-tdep.c
index b923c5c..0d41198 100644
--- a/gdb/aarch64-fbsd-tdep.c
+++ b/gdb/aarch64-fbsd-tdep.c
@@ -134,7 +134,7 @@ const struct regset aarch64_fbsd_fpregset =
     regcache_supply_regset, regcache_collect_regset
   };
 
-/* Implement the "regset_from_core_section" gdbarch method.  */
+/* Implement the "iterate_over_regset_sections" gdbarch method.  */
 
 static void
 aarch64_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch,
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index 67046c4..34ba0d8 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -582,7 +582,7 @@ aarch64_linux_collect_sve_regset (const struct regset *regset,
 			    size - SVE_HEADER_SIZE);
 }
 
-/* Implement the "regset_from_core_section" gdbarch method.  */
+/* Implement the "iterate_over_regset_sections" gdbarch method.  */
 
 static void
 aarch64_linux_iterate_over_regset_sections (struct gdbarch *gdbarch,
diff --git a/gdb/arm-fbsd-tdep.c b/gdb/arm-fbsd-tdep.c
index 417a805..de94d06 100644
--- a/gdb/arm-fbsd-tdep.c
+++ b/gdb/arm-fbsd-tdep.c
@@ -150,7 +150,7 @@ const struct regset arm_fbsd_vfpregset =
     regcache_supply_regset, regcache_collect_regset
   };
 
-/* Implement the "regset_from_core_section" gdbarch method.  */
+/* Implement the "iterate_over_regset_sections" gdbarch method.  */
 
 static void
 arm_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch,
diff --git a/gdb/gdbcore.h b/gdb/gdbcore.h
index 66e81df..0a69d36a 100644
--- a/gdb/gdbcore.h
+++ b/gdb/gdbcore.h
@@ -269,8 +269,7 @@ private:
   std::string m_storage;
 };
 
-/* NOTE: cagney/2004-04-05: Replaced by "regset.h" and
-   regset_from_core_section().  */
+/* Replaced by the "iterate_over_regset_sections" gdbarch method.  */
 extern void deprecated_add_core_fns (struct core_fns *cf);
 extern int default_core_sniffer (struct core_fns *cf, bfd * abfd);
 extern int default_check_format (bfd * abfd);
diff --git a/gdb/riscv-fbsd-tdep.c b/gdb/riscv-fbsd-tdep.c
index 8a92959..6e0eb2b 100644
--- a/gdb/riscv-fbsd-tdep.c
+++ b/gdb/riscv-fbsd-tdep.c
@@ -81,7 +81,7 @@ const struct regset riscv_fbsd_fpregset =
     regcache_supply_regset, regcache_collect_regset
   };
 
-/* Implement the "regset_from_core_section" gdbarch method.  */
+/* Implement the "iterate_over_regset_sections" gdbarch method.  */
 
 static void
 riscv_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch,


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-01-24 11:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-24 11:35 [binutils-gdb] Update comments about removed function Christian Biesinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).